[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5472: Initialize _aggregateMetric in constructor

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #5472:
URL: https://github.com/apache/incubator-pinot/pull/5472#discussion_r432981331



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -344,7 +346,7 @@ private boolean isNoDictionaryColumn(Set<String> noDictionaryColumns, Set<String
       // if the column is part of noDictionary set from table config
       if (fieldSpec instanceof DimensionFieldSpec && _aggregateMetrics && (dataType == FieldSpec.DataType.STRING ||
           dataType == FieldSpec.DataType.BYTES)) {
-        _logger.info("Not creating dictionary in consuming segment for column {} of type {}", column, dataType.toString());
+        _logger.info("Will create dictionary in consuming segment for column {} of type {}", column, dataType.toString());

Review comment:
       Let's be more explicit, to clarify that that noDictionary is being overwritten by aggregateMetrics for the column.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org