You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/08/22 22:28:00 UTC
[GitHub] drcrallen opened a new pull request #6219: Add optional `name` to
top level of FilteredAggregatorFactory
drcrallen opened a new pull request #6219: Add optional `name` to top level of FilteredAggregatorFactory
URL: https://github.com/apache/incubator-druid/pull/6219
The `FilteredAggregatorFactory` behavior is kind of odd in the sense that the resulting `name` for the aggregation is not set at the top level, but rather is set by the delegate aggregation. This makes any query planning or auto-generation items have a need to special case the `FilteredAggregatorFactory`.
This PR adds a `name` field to `FilteredAggregatorFactory` which is only used if the delegate aggregator factory does not have a `name` set. As such it retains prior behavior but allows people to (optionally) migrate to using a top-level `name` field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org