[jira] [Comment Edited] (SLING-3421) logback initialization does not initialize correct loggers if there's a single false one

["Stefan Egli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915683#comment-13915683 ] 

Stefan Egli edited comment on SLING-3421 at 2/28/14 11:25 AM:
--------------------------------------------------------------

the corresponding logger misconfiguration that caused this was:
{code}
<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0"
	xmlns:jcr="http://www.jcp.org/jcr/1.0" jcr:primaryType="sling:OsgiConfig"
	org.apache.sling.commons.log.file="logs/my-granite-project.log"
	org.apache.sling.commons.log.level="debug"
	org.apache.sling.commons.log.names="[demo.demo]"
	org.apache.sling.commons.log.pattern="\{0,date,yyyy-MM-dd HH:mm:ss.SSS} {4} [{3}] {5}" />
{code}


was (Author: egli):
the corresponding logger misconfiguration that caused this was:

<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0"
	xmlns:jcr="http://www.jcp.org/jcr/1.0" jcr:primaryType="sling:OsgiConfig"
	org.apache.sling.commons.log.file="logs/my-granite-project.log"
	org.apache.sling.commons.log.level="debug"
	org.apache.sling.commons.log.names="[demo.demo]"
	org.apache.sling.commons.log.pattern="\{0,date,yyyy-MM-dd HH:mm:ss.SSS} {4} [{3}] {5}" />


> logback initialization does not initialize correct loggers if there's a single false one
> ----------------------------------------------------------------------------------------
>
>                 Key: SLING-3421
>                 URL: https://issues.apache.org/jira/browse/SLING-3421
>             Project: Sling
>          Issue Type: Bug
>          Components: Commons
>            Reporter: Stefan Egli
>            Assignee: Chetan Mehrotra
>
> If you configure a logger wrongly, which eg results in this stacktrace:
> {code}
> java.io.IOException: Bad file descriptor
> 	at java.io.FileOutputStream.writeBytes(Native Method)
> 	at java.io.FileOutputStream.write(FileOutputStream.java:282)
> 	at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:65)
> 	at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:123)
> 	at ch.qos.logback.core.recovery.ResilientOutputStreamBase.flush(ResilientOutputStreamBase.java:79)
> 	at org.apache.sling.commons.log.logback.internal.util.LoggerSpecificEncoder.doEncode(LoggerSpecificEncoder.java:46)
> 	at org.apache.sling.commons.log.logback.internal.util.LoggerSpecificEncoder.doEncode(LoggerSpecificEncoder.java:34)
> 	at ch.qos.logback.core.OutputStreamAppender.writeOut(OutputStreamAppender.java:188)
> 	at ch.qos.logback.core.FileAppender.writeOut(FileAppender.java:206)
> 	at ch.qos.logback.core.OutputStreamAppender.subAppend(OutputStreamAppender.java:212)
> 	at ch.qos.logback.core.rolling.RollingFileAppender.subAppend(RollingFileAppender.java:175)
> 	at ch.qos.logback.core.OutputStreamAppender.append(OutputStreamAppender.java:103)
> 	at ch.qos.logback.core.UnsynchronizedAppenderBase.doAppend(UnsynchronizedAppenderBase.java:88)
> 	at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:48)
> 	at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:273)
> 	at ch.qos.logback.classic.Logger.callAppenders(Logger.java:260)
> 	at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:442)
> 	at ch.qos.logback.classic.Logger.filterAndLog_0_Or3Plus(Logger.java:396)
> 	at ch.qos.logback.classic.Logger.log(Logger.java:788)
> 	at org.eclipse.jetty.util.log.JettyAwareLogger.log(JettyAwareLogger.java:620)
> {code}
> logback initialization stops completely and no other logger will be honored.
> I think the logback initialization should continue and just mark the failing one prominently, instead of completely stopping.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)