[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #626: Keep terminal open after debug ends

["mbeckerle (via GitHub)" <gi...@apache.org>]

mbeckerle commented on code in PR #626:
URL: https://github.com/apache/daffodil-vscode/pull/626#discussion_r1187603722


##########
src/utils.ts:
##########
@@ -26,6 +26,18 @@ import { TDMLConfig } from './adapter/activateDaffodilDebug'
 const defaultConf = vscode.workspace.getConfiguration()
 let currentConfig: vscode.DebugConfiguration
 
+// if active termainl is one of these, use the active terminal instead of making a new one
+const allowedShells = [

Review Comment:
   Hmmm. Why allow all these shells? Are we really going to attempt to support (and test!) all of these? 
   
   My preference would be to put in ONLY entries that we have specific testing of them. Comment the others out and make a note there that these could be supported, but would need testing to cover them. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org