You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2019/03/09 00:16:00 UTC
[jira] [Comment Edited] (SOLR-13300) Reproducing seed in master for
DistributedFacetExistsSmallTest
[ https://issues.apache.org/jira/browse/SOLR-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788401#comment-16788401 ]
Mark Miller edited comment on SOLR-13300 at 3/9/19 12:15 AM:
-------------------------------------------------------------
bq. i'm not sure why exactly that was a neccessary change given that ConcurrentHashMap will already "protect itself" from having a null key
It's been a while, but I assume that was done to work around how ConcurrentHashMap was handling a null key.
If I didn't see realfails with this I would have walked it back, I know that. It was an annoying change for something that should be so trivial.
was (Author: markrmiller@gmail.com):
bq. i'm not sure why exactly that was a neccessary change given that ConcurrentHashMap will already "protect itself" from having a null key
It's been a while, but I assume that was done to work around how ConcurrentHashMap was handling a null key.
If I didn't see rail fails with this I would have walked it back, I know that. It was an annoying change for something that should be so trivial.
> Reproducing seed in master for DistributedFacetExistsSmallTest
> --------------------------------------------------------------
>
> Key: SOLR-13300
> URL: https://issues.apache.org/jira/browse/SOLR-13300
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Priority: Major
>
> ant test -Dtestcase=DistributedFacetExistsSmallTest -Dtests.method=test -Dtests.seed=662700D3AC576EAB -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=ca -Dtests.timezone=Europe/Ulyanovsk -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
> This test hasn't been changed lately, but reproduces 3/3 for me.
>
> {code:java}
> 2> NOTE: reproduce with: ant test -Dtestcase=DistributedFacetExistsSmallTest -Dtests.method=test -Dtests.seed=662700D3AC576EAB -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=ca -Dtests.timezone=Europe/Ulyanovsk -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
> [junit4] FAILURE 19.1s | DistributedFacetExistsSmallTest.test <<<
> [junit4] > Throwable #1: junit.framework.AssertionFailedError: .facet_counts.facet_fields.t_s.null:0!=null
> [junit4] > at __randomizedtesting.SeedInfo.seed([662700D3AC576EAB:EE733F0902AB0353]:0)
> [junit4] > at junit.framework.Assert.fail(Assert.java:57)
> [junit4] > at org.apache.solr.BaseDistributedSearchTestCase.compareSolrResponses(BaseDistributedSearchTestCase.java:999)
> [junit4] > at org.apache.solr.BaseDistributedSearchTestCase.compareResponses(BaseDistributedSearchTestCase.java:1026)
> [junit4] > at org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:680)
> [junit4] > at org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:643)
> [junit4] > at org.apache.solr.handler.component.DistributedFacetExistsSmallTest.checkRandomParams(DistributedFacetExistsSmallTest.java:139)
> [junit4] > at org.apache.solr.handler.component.DistributedFacetExistsSmallTest.test(DistributedFacetExistsSmallTest.java:87)
> [junit4] > at org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:1082)
> [junit4] > at org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:1054)
> [junit4] > at java.lang.Thread.run(Thread.java:748)
> [junit4] 2> NOTE: leaving temporary files on disk at: /Users/Erick/apache/solrVersions/playspace/solr/build/solr-core/test/J0/temp/solr.handler.component.DistributedFacetExistsSmallTest_662700D3AC576EAB-001
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org