You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/16 20:44:35 UTC
[GitHub] [shardingsphere] nnomier opened a new pull request, #21026: 20362 Add More Unit Tests for SQLUtil to increase coverage
nnomier opened a new pull request, #21026:
URL: https://github.com/apache/shardingsphere/pull/21026
Add unit tests for the following Methods: isReadOnly, trimComment, trimSemicolon
Fixes #20362.
Changes proposed in this pull request:
- Add test for isReadOnly
- Add test for trimComment
- Add test for trimSemiColon
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] mlycore commented on pull request #21026: 20362 Add More Unit Tests for SQLUtil to increase coverage
Posted by GitBox <gi...@apache.org>.
mlycore commented on PR #21026:
URL: https://github.com/apache/shardingsphere/pull/21026#issuecomment-1249864209
Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #21026: 20362 Add More Unit Tests for SQLUtil to increase coverage
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #21026:
URL: https://github.com/apache/shardingsphere/pull/21026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org