You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Arnaud Simon (JIRA)" <qp...@incubator.apache.org> on 2008/02/29 15:58:51 UTC
[jira] Created: (QPID-824) Several tests don't clean resources
(connections should be closed)
Several tests don't clean resources (connections should be closed)
-------------------------------------------------------------------
Key: QPID-824
URL: https://issues.apache.org/jira/browse/QPID-824
Project: Qpid
Issue Type: Bug
Components: Java Tests
Affects Versions: M3
Reporter: Arnaud Simon
Fix For: M3
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-824) Several tests don't clean resources
(connections should be closed)
Posted by "Arnaud Simon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573780#action_12573780 ]
Arnaud Simon commented on QPID-824:
-----------------------------------
The folowing tests don't do a proper resource cleaning:
client/src/test/java/org/apache/qpid/test/unit/basic/close/CloseTests.java
client/src/test/java/org/apache/qpid/test/unit/basic/InvalidDestinationTest.java
client/src/test/java/org/apache/qpid/test/unit/basic/LargeMessageTest.java
client/src/test/java/org/apache/qpid/test/unit/basic/PubSubTwoConnectionTest.java
client/src/test/java/org/apache/qpid/test/unit/client/AMQConnectionTest.java
client/src/test/java/org/apache/qpid/test/unit/client/connection/ConnectionTest.java
client/src/test/java/org/apache/qpid/test/unit/client/message/ObjectMessageTest.java
client/src/test/java/org/apache/qpid/test/unit/close/CloseBeforeAckTest.java
client/src/test/java/org/apache/qpid/test/unit/message/StreamMessageTest.java
client/src/test/java/org/apache/qpid/test/unit/topic/TopicPublisherTest.java
Would be good if somebody can double check whether this list is exhaustive.
> Several tests don't clean resources (connections should be closed)
> -------------------------------------------------------------------
>
> Key: QPID-824
> URL: https://issues.apache.org/jira/browse/QPID-824
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M3
> Reporter: Arnaud Simon
> Fix For: M3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-824) Several tests don't clean resources
(connections should be closed)
Posted by "Arnaud Simon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575715#action_12575715 ]
Arnaud Simon commented on QPID-824:
-----------------------------------
I have checked in a patch for the above tests to close resources. I have also changed DurableSubscriptionTest#testDurability to unsubscribe the durable subscriber as the session is created as no ack the test cannot be run twice in a row because messages are redelivered (messages are not acked)
> Several tests don't clean resources (connections should be closed)
> -------------------------------------------------------------------
>
> Key: QPID-824
> URL: https://issues.apache.org/jira/browse/QPID-824
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M3
> Reporter: Arnaud Simon
> Fix For: M3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-824) Several tests don't clean resources
(connections should be closed)
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner updated QPID-824:
-------------------------------
Assignee: Arnaud Simon
> Several tests don't clean resources (connections should be closed)
> -------------------------------------------------------------------
>
> Key: QPID-824
> URL: https://issues.apache.org/jira/browse/QPID-824
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M3
> Reporter: Arnaud Simon
> Assignee: Arnaud Simon
> Fix For: M3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-824) Several tests don't clean resources
(connections should be closed)
Posted by "Arnaud Simon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Simon resolved QPID-824.
-------------------------------
Resolution: Fixed
This is solved but as mentioned QpidTestcase will benefit in closing the connection.
> Several tests don't clean resources (connections should be closed)
> -------------------------------------------------------------------
>
> Key: QPID-824
> URL: https://issues.apache.org/jira/browse/QPID-824
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M3
> Reporter: Arnaud Simon
> Assignee: Arnaud Simon
> Fix For: M4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-824) Several tests don't clean resources
(connections should be closed)
Posted by "Rafael H. Schloming (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575774#action_12575774 ]
Rafael H. Schloming commented on QPID-824:
------------------------------------------
Rather than closing connections manually in each test case, we could probably modify QpidTestCase to track the connections that it gives out via it's getConnection(..) methods, and automatically close them on teardown. This would at least narrow the problem to only those tests that don't extend QpidTestCase, which should be a diminishing number.
> Several tests don't clean resources (connections should be closed)
> -------------------------------------------------------------------
>
> Key: QPID-824
> URL: https://issues.apache.org/jira/browse/QPID-824
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M3
> Reporter: Arnaud Simon
> Fix For: M3
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.