You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/06/22 14:09:15 UTC
[GitHub] [incubator-linkis] wForget commented on a diff in pull request #2308: [LINKIS #1632] Add linkis-engineplugin-elasticsearch module
wForget commented on code in PR #2308:
URL: https://github.com/apache/incubator-linkis/pull/2308#discussion_r903795715
##########
linkis-engineconn-plugins/engineconn-plugins/elasticsearch/src/main/scala/org/apache/linkis/engineplugin/elasticsearch/executer/client/impl/ResponseHandlerImpl.scala:
##########
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.linkis.engineplugin.elasticsearch.executer.client.impl
+
+import java.nio.charset.Charset
+import com.fasterxml.jackson.databind.node.{ArrayNode, ObjectNode}
+import org.apache.linkis.common.utils.Utils
+import org.apache.linkis.engineplugin.elasticsearch.executer.client.ResponseHandler._
+import org.apache.linkis.engineplugin.elasticsearch.executer.client.ResponseHandler
+import org.apache.linkis.storage.domain._
+import org.apache.linkis.storage.resultset.table.TableRecord
+import org.apache.http.entity.ContentType
+import org.apache.http.util.EntityUtils
+import org.apache.linkis.engineplugin.elasticsearch.exception.EsConvertResponseException
+import org.apache.linkis.engineplugin.elasticsearch.executer.client.{ElasticSearchJsonResponse, ElasticSearchResponse, ElasticSearchTableResponse, ResponseHandler}
+import org.elasticsearch.client.Response
+
+import scala.collection.JavaConverters._
+import scala.collection.mutable.ArrayBuffer
+
+class ResponseHandlerImpl extends ResponseHandler {
+
+ // scalastyle:off
+ override def handle(response: Response): ElasticSearchResponse = {
+ val contentType = ContentType.get(response.getEntity).getMimeType.toLowerCase
+ val charSet = ContentType.get(response.getEntity).getCharset match {
+ case c: Charset => c
+ case _ => Charset.forName("UTF-8")
+ }
+ val contentBytes = EntityUtils.toByteArray(response.getEntity)
+
+ if (contentBytes == null || contentBytes.isEmpty) {
+ throw EsConvertResponseException("EsEngineExecutor convert response fail, response content is empty.")
+ }
+
+ val jsonNode = Utils.tryCatch{ contentType match {
+ case "application/yaml" =>
+ yamlMapper.readTree(contentBytes)
+ case "application/cbor" =>
+ cborMapper.readTree(contentBytes)
+ case "application/smile" =>
+ smileMapper.readTree(contentBytes)
+// case "text/csv" =>
+// csvMapper.readTree(contentBytes)
+// case "text/tab-separated-values" =>
+// csvMapper.readTree(contentBytes)
+// val schema = csvMapper.schemaFor(classOf[Array[Byte]]).withColumnSeparator('\t')
+// val reader = csvMapper.readerFor(classOf[Array[Byte]]).`with`(schema)
+// reader.readValue(contentBytes)
+ case _ =>
+ jsonMapper.readTree(contentBytes)
+ }
+ } {
+ case t: Throwable => {
+ warn("deserialize response content error, {}", t)
+ null
+ }
+ }
+
+ if (jsonNode == null) {
+ ElasticSearchJsonResponse(new String(contentBytes, charSet))
+ }
+
+ var isTable = false
+ val columns = ArrayBuffer[Column]()
+ val records = new ArrayBuffer[TableRecord]
+
+ // es json runType response
+ jsonNode.at("/hits/hits") match {
+ case hits: ArrayNode => {
+ isTable = true
+ columns += Column("_index", StringType, "")
+ columns += Column("_type", StringType, "")
+ columns += Column("_id", StringType, "")
+ columns += Column("_score", DoubleType, "")
+ hits.asScala.foreach {
+ case obj: ObjectNode => {
+ val lineValues = new Array[Any](columns.length).toBuffer
+ obj.fields().asScala.foreach(entry => {
+ val key = entry.getKey
+ val value = entry.getValue
+ if ("_source".equals(key.trim)) {
+ value.fields().asScala.foreach(sourceEntry => {
+ val sourcekey = sourceEntry.getKey
+ val sourcevalue = sourceEntry.getValue
+ val index = columns.indexWhere(_.columnName.equals(sourcekey))
+ if (index < 0) {
+ columns += Column(sourcekey, getNodeDataType(sourcevalue), "")
+ lineValues += getNodeValue(sourcevalue)
+ } else {
+ lineValues(index) = getNodeValue(sourcevalue)
+ }
+ })
+ } else {
+ val index = columns.indexWhere(_.columnName.equals(key))
+ if (index < 0) {
+ columns += Column(key, getNodeDataType(value), "")
+ lineValues += getNodeValue(value)
+ } else {
+ lineValues(index) = getNodeValue(value)
+ }
+ }
+ })
+ records += new TableRecord(lineValues.toArray)
+ }
+ case _ =>
+ }
+ }
+ case _ =>
+ }
+
+ // es sql runType response
+ jsonNode.at("/rows") match {
+ case rows: ArrayNode => {
+ isTable = true
+ jsonNode.get("columns").asInstanceOf[ArrayNode]
+ .asScala
+ .foreach(node => {
+ val name = node.get("name").asText()
+ val estype = node.get("type").asText().trim
+ columns += Column(name, getNodeTypeByEsType(estype), "")
+ })
+ rows.asScala.foreach {
+ case row: ArrayNode => {
+ val lineValues = new ArrayBuffer[Any]()
+ row.asScala.foreach(node => lineValues += getNodeValue(node))
+ records += new TableRecord(lineValues.toArray)
+ }
+ case _ =>
+ }
+ }
+ case _ =>
+ }
+
+ // write result
+ if (isTable) {
+ ElasticSearchTableResponse(columns.toArray, records.toArray)
+ } else {
+ ElasticSearchJsonResponse(new String(contentBytes, charSet))
+ }
+ }
+ // scalastyle:on
+
+// def writeText(content: String, storePath: String, alias: String, proxyUser: String): String = {
Review Comment:
thanks, fixed
##########
linkis-engineconn-plugins/engineconn-plugins/elasticsearch/src/main/scala/org/apache/linkis/engineplugin/elasticsearch/conf/ElasticSearchConfiguration.scala:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.linkis.engineplugin.elasticsearch.conf
+
+import org.apache.linkis.common.conf.{ByteType, CommonVars}
+
+object ElasticSearchConfiguration {
+
+ // es client
+ val ES_CLUSTER = CommonVars("wds.linkis.es.cluster", "127.0.0.1:9200")
+ val ES_DATASOURCE_NAME = CommonVars("wds.linkis.datasource", "default_datasource")
Review Comment:
thanks, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org