You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/06/11 23:45:30 UTC
[PR] Disable `datafusion-cli tests for hash_collision tets [datafusion]
alamb opened a new pull request, #16382:
URL: https://github.com/apache/datafusion/pull/16382
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/16378
## Rationale for this change
As described on https://github.com/apache/datafusion/issues/16378, the `datafusion-cli` tests started failing after https://github.com/apache/datafusion/pull/16300 because now it tries to fetch credentials when creating a table (rather than just accessing it)
It turns out that there is something in the github ci runner builder environment that triggers trying to fetch credentials from the AWS metastore which causes an error
Since the point of the hash collisions test is to verify that the core hash operators (hash join, merge join) don't get the wrong answers when there are hash collisions, there is no need to run the `datafusion-cli` tests
## What changes are included in this PR?
Disable `datafusion-cli` tests as part of the extended suite (they are already run on normal CI jobs)
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Disable `datafusion-cli` tests for hash_collision tests, fix extended CI [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16382:
URL: https://github.com/apache/datafusion/pull/16382#issuecomment-2966480185
> fair point!
THank you for agreeing. I have to admit it seems somewhat like cheating, but I still think it is true 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Disable `datafusion-cli` tests for hash_collision tests, fix extended CI [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #16382:
URL: https://github.com/apache/datafusion/pull/16382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org