You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/24 15:11:00 UTC

[jira] [Commented] (PARQUET-1775) Deprecate AvroParquetWriter Builder Hadoop Path

    [ https://issues.apache.org/jira/browse/PARQUET-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023011#comment-17023011 ] 

ASF GitHub Bot commented on PARQUET-1775:
-----------------------------------------

belugabehr commented on pull request #750: PARQUET-1775: Deprecate AvroParquetWriter Builder Hadoop Path
URL: https://github.com/apache/parquet-mr/pull/750
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [PARQUET-1775](https://issues.apache.org/jira/browse/PARQUET/PARQUET-1775) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-1775
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deprecate AvroParquetWriter Builder Hadoop Path
> -----------------------------------------------
>
>                 Key: PARQUET-1775
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1775
>             Project: Parquet
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>              Labels: pull-request-available
>
> Trying to write a sample program with Parquet and came across the following quark:
>  
> The {{AvroParquetWriter}} has no qualms about building one using {{org.apache.hadoop.fs.Path}}.  However, doing so in {{AvroParquetReader}} is deprecated.  I think it's appropriate to remove all dependencies of Hadoop from this simple reader/writer API.
>  
> To make it consistent, also deprecate the use of {{org.apache.hadoop.fs.Path}} in the {{AvroParquetWriter.}}
>  
> [https://github.com/apache/parquet-mr/blob/8c1bc9bcdeeac8178fecf61d18dc56913907fd46/parquet-avro/src/main/java/org/apache/parquet/avro/AvroParquetWriter.java#L38]
>  
> https://github.com/apache/parquet-mr/blob/8c1bc9bcdeeac8178fecf61d18dc56913907fd46/parquet-avro/src/main/java/org/apache/parquet/avro/AvroParquetReader.java#L47



--
This message was sent by Atlassian Jira
(v8.3.4#803005)