You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/11 13:37:03 UTC

[GitHub] [incubator-doris-flink-connector] madongz opened a new pull request, #34: add 2pc config

madongz opened a new pull request, #34:
URL: https://github.com/apache/incubator-doris-flink-connector/pull/34

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   add config to enable 2pc.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris-flink-connector] JNSimba commented on pull request #34: add 2pc config

Posted by GitBox <gi...@apache.org>.
JNSimba commented on PR #34:
URL: https://github.com/apache/incubator-doris-flink-connector/pull/34#issuecomment-1153589257

   Is it possible to automatically adapt to non-2pc scenes? There is no need to add configuration parameters. For example, after doris enables 2pc, it will be submitted with 2pc. If 2pc is not enabled, the streamload operation will be performed directly. I feel like this is a better experience


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris-flink-connector] JNSimba merged pull request #34: add 2pc config

Posted by GitBox <gi...@apache.org>.
JNSimba merged PR #34:
URL: https://github.com/apache/doris-flink-connector/pull/34


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris-flink-connector] stalary commented on a diff in pull request #34: add 2pc config

Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #34:
URL: https://github.com/apache/doris-flink-connector/pull/34#discussion_r908307271


##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/DorisStreamLoad.java:
##########
@@ -232,10 +233,12 @@ public void startLoad(long chkID) throws IOException{
             putBuilder.setUrl(loadUrlStr)
                     .baseAuth(user, passwd)
                     .addCommonHeader()
-                    .enable2PC()

Review Comment:
   why not use .enable2PC(enable2PC)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org