You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Thomas Recloux (JIRA)" <ji...@codehaus.org> on 2008/04/17 18:51:55 UTC
[jira] Created: (MEAR-86) Add a property to automatically add jars
dependencies into application.xml (TEST AND PATCH ATTACHED).
Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
-----------------------------------------------------------------------------------------------------
Key: MEAR-86
URL: http://jira.codehaus.org/browse/MEAR-86
Project: Maven 2.x Ear Plugin
Issue Type: Improvement
Affects Versions: 2.3.1
Reporter: Thomas Recloux
Attachments: MEAR-86-maven-ear-plugin.patch
Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MEAR-86) Add a property to automatically add
jars dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Martijn Verburg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155364#action_155364 ]
Martijn Verburg commented on MEAR-86:
-------------------------------------
Hi Stephane, is there anything extra that needs to be done to apply this patch? My understanding is that only committers can do so?
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: jar-sample-three-with-deps-1.0.jar, MEAR-86-maven-ear-plugin-with_tests.patch, MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MEAR-86) Add a property to automatically add jars
dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephane Nicoll updated MEAR-86:
--------------------------------
Fix Version/s: 2.3.2
your patch misses the project-043 dir but it's not a big deal.
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MEAR-86) Add a property to
automatically add jars dependencies into application.xml (TEST AND PATCH
ATTACHED).
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=166625#action_166625 ]
Stephane Nicoll edited comment on MEAR-86 at 2/22/09 9:58 AM:
--------------------------------------------------------------
The patch is missing some stuff but I guess I'll be able to handle it. Thomas, the test case is wrong. Only one lib is added in the application.xml which certainly not reflect what should be done ...
was (Author: sni):
The patch is missing some stuff but I guess I'll be able to handle it
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: jar-sample-three-with-deps-1.0.jar, MEAR-86-maven-ear-plugin-with_tests.patch, MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MEAR-86) Add a property to automatically add
jars dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155368#action_155368 ]
Stephane Nicoll commented on MEAR-86:
-------------------------------------
It's flagged for the next release so we just need to apply it. Unfortunately, I have no time to work on this for the moment. Let me put it back in the pool.
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: jar-sample-three-with-deps-1.0.jar, MEAR-86-maven-ear-plugin-with_tests.patch, MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MEAR-86) Add a property to automatically add
jars dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=166625#action_166625 ]
Stephane Nicoll commented on MEAR-86:
-------------------------------------
The patch is missing some stuff but I guess I'll be able to handle it
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: jar-sample-three-with-deps-1.0.jar, MEAR-86-maven-ear-plugin-with_tests.patch, MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MEAR-86) Add a property to automatically add jars
dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephane Nicoll closed MEAR-86.
-------------------------------
Resolution: Fixed
Applied with modifications has the patch contained errors.
Renamed option to 'includeLibInApplicationXml' for consistency.
Thanks!
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: jar-sample-three-with-deps-1.0.jar, MEAR-86-maven-ear-plugin-with_tests.patch, MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MEAR-86) Add a property to automatically add jars
dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Thomas Recloux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Recloux updated MEAR-86:
-------------------------------
Attachment: jar-sample-three-with-deps-1.0.jar
A Jar added to the test repo and userd by the new test.
Path : src/test/resources/m2repo/eartest/jar-sample-three-with-deps/1.0/jar-sample-three-with-deps-1.0.jar
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: jar-sample-three-with-deps-1.0.jar, MEAR-86-maven-ear-plugin-with_tests.patch, MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MEAR-86) Add a property to automatically add
jars dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MEAR-86 started by Stephane Nicoll.
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: jar-sample-three-with-deps-1.0.jar, MEAR-86-maven-ear-plugin-with_tests.patch, MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MEAR-86) Add a property to automatically add jars
dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Thomas Recloux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Recloux updated MEAR-86:
-------------------------------
Attachment: MEAR-86-maven-ear-plugin.patch
The patch
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Attachments: MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MEAR-86) Add a property to automatically add jars
dependencies into application.xml (TEST AND PATCH ATTACHED).
Posted by "Thomas Recloux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MEAR-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Recloux updated MEAR-86:
-------------------------------
Attachment: MEAR-86-maven-ear-plugin-with_tests.patch
The complete patch including tests.
Replaces the previous one
> Add a property to automatically add jars dependencies into application.xml (TEST AND PATCH ATTACHED).
> -----------------------------------------------------------------------------------------------------
>
> Key: MEAR-86
> URL: http://jira.codehaus.org/browse/MEAR-86
> Project: Maven 2.x Ear Plugin
> Issue Type: Improvement
> Affects Versions: 2.3.1
> Reporter: Thomas Recloux
> Assignee: Stephane Nicoll
> Fix For: 2.3.2
>
> Attachments: MEAR-86-maven-ear-plugin-with_tests.patch, MEAR-86-maven-ear-plugin.patch
>
>
> Before this issue resolution http://jira.codehaus.org/browse/MNG-826 , all jar dependencies were added into the application.xml. After the resolution, it was not added and a property was added on the javaModule element in order to add it into the application.xml.
> With a big ear project with a lot of direct or transitive dependencies, it is becoming really long and a source of errors when a transitive dependency is changing.
> My application server (JBoss 4.0.5GA) needs to add the jar modules in the application.xml.
> The default behaviour should not be changed, I added a property which includes all jar dependencies in the application.xml. If the property is not set, nothing changes.
> The patch was built against the ear plugin's trunk, it includes a test (project 43).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira