You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/28 19:00:28 UTC
[GitHub] [geode] nonbinaryprogrammer opened a new pull request #6725: GEODE-9169: remove netty context switch
nonbinaryprogrammer opened a new pull request #6725:
URL: https://github.com/apache/geode/pull/6725
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6725: GEODE-9169: remove netty context switch
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690673992
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -257,8 +204,6 @@ public void channelInactive(ChannelHandlerContext ctx) {
logger.debug("GeodeRedisServer-Connection closing with " + ctx.channel().remoteAddress());
}
- commandQueue.clear();
- commandQueue.offer(TERMINATE_COMMAND);
Review comment:
It looks like TERMINATE_COMMAND is no longer used. This class creates in a private static final so I think that static should also be removed
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -94,7 +94,7 @@ public GeodeRedisServer(String bindAddress, int port, InternalCache cache) {
nettyRedisServer = new NettyRedisServer(() -> cache.getInternalDistributedSystem().getConfig(),
regionProvider, pubSub,
this::allowUnsupportedCommands, this::shutdown, port, bindAddress, redisStats,
- redisCommandExecutor, member);
+ member);
Review comment:
shouldn't the redisCommandExecutor field be removed from this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6725: GEODE-9169: remove netty context switch
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690671958
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -94,7 +94,7 @@ public GeodeRedisServer(String bindAddress, int port, InternalCache cache) {
nettyRedisServer = new NettyRedisServer(() -> cache.getInternalDistributedSystem().getConfig(),
regionProvider, pubSub,
this::allowUnsupportedCommands, this::shutdown, port, bindAddress, redisStats,
- redisCommandExecutor, member);
+ member);
Review comment:
This executor can be completely removed from the class now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6725: GEODE-9169: remove netty context switch
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690489701
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
##########
@@ -176,8 +176,8 @@ public void initChannel(SocketChannel socketChannel) {
pipeline.addLast(new WriteTimeoutHandler(10));
pipeline.addLast(ExecutionHandlerContext.class.getSimpleName(),
new ExecutionHandlerContext(socketChannel, regionProvider, pubsub,
- allowUnsupportedSupplier, shutdownInvoker, redisStats, backgroundExecutor,
- redisPasswordBytes, getPort(), member));
+ allowUnsupportedSupplier, shutdownInvoker, redisStats, redisPasswordBytes,
Review comment:
The `backgroundExecutor` removed here should also be removed from the constructor and can then also be removed from `GeodeRedisServer`.
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -94,7 +94,7 @@ public GeodeRedisServer(String bindAddress, int port, InternalCache cache) {
nettyRedisServer = new NettyRedisServer(() -> cache.getInternalDistributedSystem().getConfig(),
regionProvider, pubSub,
this::allowUnsupportedCommands, this::shutdown, port, bindAddress, redisStats,
- redisCommandExecutor, member);
+ member);
Review comment:
This executor can be completely removed from the class now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6725: GEODE-9169: remove netty context switch
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690489701
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
##########
@@ -176,8 +176,8 @@ public void initChannel(SocketChannel socketChannel) {
pipeline.addLast(new WriteTimeoutHandler(10));
pipeline.addLast(ExecutionHandlerContext.class.getSimpleName(),
new ExecutionHandlerContext(socketChannel, regionProvider, pubsub,
- allowUnsupportedSupplier, shutdownInvoker, redisStats, backgroundExecutor,
- redisPasswordBytes, getPort(), member));
+ allowUnsupportedSupplier, shutdownInvoker, redisStats, redisPasswordBytes,
Review comment:
The `backgroundExecutor` removed here should also be removed from the constructor and can then also be removed from `GeodeRedisServer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer merged pull request #6725: GEODE-9169: remove netty context switch
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer merged pull request #6725:
URL: https://github.com/apache/geode/pull/6725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6725: GEODE-9169: remove netty context switch
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690673992
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -257,8 +204,6 @@ public void channelInactive(ChannelHandlerContext ctx) {
logger.debug("GeodeRedisServer-Connection closing with " + ctx.channel().remoteAddress());
}
- commandQueue.clear();
- commandQueue.offer(TERMINATE_COMMAND);
Review comment:
It looks like TERMINATE_COMMAND is no longer used. This class creates in a private static final so I think that static should also be removed
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -94,7 +94,7 @@ public GeodeRedisServer(String bindAddress, int port, InternalCache cache) {
nettyRedisServer = new NettyRedisServer(() -> cache.getInternalDistributedSystem().getConfig(),
regionProvider, pubSub,
this::allowUnsupportedCommands, this::shutdown, port, bindAddress, redisStats,
- redisCommandExecutor, member);
+ member);
Review comment:
shouldn't the redisCommandExecutor field be removed from this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on a change in pull request #6725: GEODE-9169: remove netty context switch
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690630827
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
##########
@@ -176,8 +176,8 @@ public void initChannel(SocketChannel socketChannel) {
pipeline.addLast(new WriteTimeoutHandler(10));
pipeline.addLast(ExecutionHandlerContext.class.getSimpleName(),
new ExecutionHandlerContext(socketChannel, regionProvider, pubsub,
- allowUnsupportedSupplier, shutdownInvoker, redisStats, backgroundExecutor,
- redisPasswordBytes, getPort(), member));
+ allowUnsupportedSupplier, shutdownInvoker, redisStats, redisPasswordBytes,
Review comment:
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on a change in pull request #6725: GEODE-9169: remove netty context switch
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690630827
##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
##########
@@ -176,8 +176,8 @@ public void initChannel(SocketChannel socketChannel) {
pipeline.addLast(new WriteTimeoutHandler(10));
pipeline.addLast(ExecutionHandlerContext.class.getSimpleName(),
new ExecutionHandlerContext(socketChannel, regionProvider, pubsub,
- allowUnsupportedSupplier, shutdownInvoker, redisStats, backgroundExecutor,
- redisPasswordBytes, getPort(), member));
+ allowUnsupportedSupplier, shutdownInvoker, redisStats, redisPasswordBytes,
Review comment:
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org