[jira] [Commented] (CALCITE-4425) Class DefaultEdge lacks a proper toString implementation

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254204#comment-17254204 ] 

Julian Hyde commented on CALCITE-4425:
--------------------------------------

The commit message seems a bit snide, especially when it read as part of the release notes. Please try to keep a neutral tone.

> Class DefaultEdge lacks a proper toString implementation
> --------------------------------------------------------
>
>                 Key: CALCITE-4425
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4425
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Liya Fan
>            Assignee: Liya Fan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It is convenient to build a graph as an object of {{DefaultDirectedGraph}}. The class has a good {{toString}} implementation, which greatly helps examining the structure of the graph. 
> However, the output of the method may be confusing. In our system, the {{toString}} method produces the following result:
> graph(vertices: [0, 1, 2, 3, 4, 5, 6], edges: [org.apache.calcite.util.graph.DefaultEdge@1a550334, org.apache.calcite.util.graph.DefaultEdge@891ce8a1, org.apache.calcite.util.graph.DefaultEdge@ba5c5190, org.apache.calcite.util.graph.DefaultEdge@c894f6b3, org.apache.calcite.util.graph.DefaultEdge@d72993fe, org.apache.calcite.util.graph.DefaultEdge@da030cc4, org.apache.calcite.util.graph.DefaultEdge@de17986f, org.apache.calcite.util.graph.DefaultEdge@e20be355, org.apache.calcite.util.graph.DefaultEdge@ef7b8a83, org.apache.calcite.util.graph.DefaultEdge@f2b672ef, org.apache.calcite.util.graph.DefaultEdge@f547e446])
> The reason is that the default edge type is {{DefaultEdge}}, and the {{DefaultEdge}} class does not have a proper {{toString}} implementation. So we want to provide one, so that it helps investigating the internals of the graph. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)