You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Simon E (JIRA)" <ji...@apache.org> on 2011/04/20 14:03:05 UTC

[jira] [Created] (THRIFT-1152) Attributes from private to protected

Attributes from private to protected
------------------------------------

                 Key: THRIFT-1152
                 URL: https://issues.apache.org/jira/browse/THRIFT-1152
             Project: Thrift
          Issue Type: Sub-task
          Components: PHP - Library
    Affects Versions: 0.7
            Reporter: Simon E
            Priority: Trivial


The TForkingServer has an attribute for the childs it creates.. now the problem is: We're having a PHP daemon which uses the TForkingServer so that it handles all connections in a seperate thread. When we have to restart the daemon (code change) the main thread doing "serve()" would be restartet but all the childs won't (we have persistent connections) stop, so i wan't to extend the class and send a sigterm to all the chils but the childs_ attribute is PRIVATE so it should be PROTECTED i think.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1152) Attributes from private to protected

Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell closed THRIFT-1152.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7
         Assignee: Jake Farrell

> Attributes from private to protected
> ------------------------------------
>
>                 Key: THRIFT-1152
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1152
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: PHP - Library
>    Affects Versions: 0.7
>            Reporter: Simon E
>            Assignee: Jake Farrell
>            Priority: Trivial
>             Fix For: 0.7
>
>         Attachments: thrift-1152.patch
>
>
> The TForkingServer has an attribute for the childs it creates.. now the problem is: We're having a PHP daemon which uses the TForkingServer so that it handles all connections in a seperate thread. When we have to restart the daemon (code change) the main thread doing "serve()" would be restartet but all the childs won't (we have persistent connections) stop, so i wan't to extend the class and send a sigterm to all the chils but the childs_ attribute is PRIVATE so it should be PROTECTED i think.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1152) Attributes from private to protected

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022245#comment-13022245 ] 

Hudson commented on THRIFT-1152:
--------------------------------

Integrated in Thrift #134 (See [https://builds.apache.org/hudson/job/Thrift/134/])
    

> Attributes from private to protected
> ------------------------------------
>
>                 Key: THRIFT-1152
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1152
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: PHP - Library
>    Affects Versions: 0.7
>            Reporter: Simon E
>            Assignee: Jake Farrell
>            Priority: Trivial
>             Fix For: 0.7
>
>         Attachments: thrift-1152.patch
>
>
> The TForkingServer has an attribute for the childs it creates.. now the problem is: We're having a PHP daemon which uses the TForkingServer so that it handles all connections in a seperate thread. When we have to restart the daemon (code change) the main thread doing "serve()" would be restartet but all the childs won't (we have persistent connections) stop, so i wan't to extend the class and send a sigterm to all the chils but the childs_ attribute is PRIVATE so it should be PROTECTED i think.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1152) Attributes from private to protected

Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell updated THRIFT-1152:
---------------------------------

    Attachment: thrift-1152.patch

Changing the TForkingServer children_ from private to protected

> Attributes from private to protected
> ------------------------------------
>
>                 Key: THRIFT-1152
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1152
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: PHP - Library
>    Affects Versions: 0.7
>            Reporter: Simon E
>            Priority: Trivial
>         Attachments: thrift-1152.patch
>
>
> The TForkingServer has an attribute for the childs it creates.. now the problem is: We're having a PHP daemon which uses the TForkingServer so that it handles all connections in a seperate thread. When we have to restart the daemon (code change) the main thread doing "serve()" would be restartet but all the childs won't (we have persistent connections) stop, so i wan't to extend the class and send a sigterm to all the chils but the childs_ attribute is PRIVATE so it should be PROTECTED i think.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira