Re: Building Sling - Errors

[Robert Munteanu <ro...@apache.org>]

Hi again and sorry for the late reply, this slipped through.

On Wed, 2016-06-15 at 21:36 +0100, David Legg wrote:
> Hi Robert + Robert,
> 
> On 15/06/16 12:29, Robert Munteanu wrote:
> > > $ svn co http://svn.apache.org/repos/asf/sling/trunk sling
> > > $ cd sling
> > > $ export MAVEN_OPTS="-Xmx1024M -XX:MaxPermSize=512m"
> > > $ mvn -DskipTests clean install
> > 
> > That works for me OOTB on my svn checkout.
> > 
> 
> Interesting!��If I follow my own recipe it works for me too!
> 
> In an attempt to simplify I had omitted to say that I don't usually�
> download the whole thing every time and instead simply do: -
> 
> � $ svn update
> 
> So this means the project folder isn't necessarily pristine every
> time I�
> run mvn.
> 
> > Can you attach the license errors that are reported in
> > ~/projects/sling/sling/launchpad/builder/target/rat.txt ?
> 
> Having looked through the rat.txt file I think the problem is it is
> a�
> little too eager to check every file for the Apache license and is�
> counting some of the Oak artifacts produced from previous attempts
> to�
> run Sling.
> 
> I'm not sure if the list accepts attachments and besides it is 941
> KB.�
> I can send it on request but in the meantime here are some extracts
> from�
> it to give you a flavour: -
> 
> 
> *****************************************************
> Summary
> -------
> Generated at: 2016-06-13T21:34:50+01:00
> Notes: 1
> Binaries: 325
> Archives: 175
> Standards: 349
> 
> Apache Licensed: 45
> Generated Documents: 0
> 
> JavaDocs are generated and so license header is optional
> Generated files do not required license headers
> 
> 304 Unknown Licenses
> 
> *******************************
> 
> Unapproved licenses:
> 
> ���/home/djl/projects/sling/sling/launchpad/builder/html.esp
> �
> /home/djl/projects/sling/sling/launchpad/builder/test/felix/bundle5/v
> ersion0.0/revision.location

(snip)

Looks like you've added some files to launchpad/buider which the
license checker tool ( rat ) flags as not having a proper license

- html.esp
- a whole sling install under test/

What you can do is

- remove that html.esp file
- move the sling install under sling/ ( launchpad/builder/sling to be
complete ) as that folder is ignored by rat by default in this project

Robert

Re: Building Sling - Errors

[David Legg <da...@searchevent.co.uk>]

Hi Robert,

Thanks very much for responding and for putting your finger on the problem!

Regards,
David Legg

On 13/07/16 11:28, Robert Munteanu wrote:
> Hi again and sorry for the late reply, this slipped through.
>
> On Wed, 2016-06-15 at 21:36 +0100, David Legg wrote:
>> On 15/06/16 12:29, Robert Munteanu wrote:
>>
>> Having looked through the rat.txt file I think the problem is it is
>> a
>> little too eager to check every file for the Apache license and is
>> counting some of the Oak artifacts produced from previous attempts
>> to
>> run Sling.
>>
>
> Looks like you've added some files to launchpad/buider which the
> license checker tool ( rat ) flags as not having a proper license
>
> - html.esp
> - a whole sling install under test/
>
> Robert
>