[GitHub] [arrow-datafusion] Weijun-H commented on a diff in pull request #5625: feat: Quote column only if has special characters

["Weijun-H (via GitHub)" <gi...@apache.org>]

Weijun-H commented on code in PR #5625:
URL: https://github.com/apache/arrow-datafusion/pull/5625#discussion_r1140979667


##########
datafusion/common/src/column.rs:
##########
@@ -112,12 +112,22 @@ impl Column {
 
     /// Serialize column into a quoted flat name string
     pub fn quoted_flat_name(&self) -> String {
-        // TODO: quote identifiers only when special characters present
-        // see: https://github.com/apache/arrow-datafusion/issues/5523
         match &self.relation {
             Some(r) => {
-                format!("{}.{}", r.to_quoted_string(), quote_identifier(&self.name))
+                let column_name = if self.name.chars().all(|c| c.is_ascii()) {

Review Comment:
   Thank you for decant explanation. It is much clear.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org