You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Savalek <gi...@git.apache.org> on 2018/07/06 14:05:06 UTC

[GitHub] zeppelin pull request #3056: [ZEPPELIN-3567] fix InterpreterContext convert(...

GitHub user Savalek opened a pull request:

    https://github.com/apache/zeppelin/pull/3056

    [ZEPPELIN-3567] fix InterpreterContext convert(...) method

    ### What is this PR for?
    After commit [7af861...](https://github.com/apache/zeppelin/commit/7af86168254e0ad08234c57043e18179fca8d04c) will be lost convert of `config`.
    This PR returning it back.
    Because of this, the status of the autocomplete was lost after the run of the paragraph.
    
    ![tab_complition_fix](https://user-images.githubusercontent.com/30798933/42382820-17e4ea92-813e-11e8-994c-4791ccbfe16f.png)
    
    ### What type of PR is it?
    Bug Fix
    
    JIRA: [ZEPPELIN-3567](https://issues.apache.org/jira/browse/ZEPPELIN-3567)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3567

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3056
    
----
commit 05f2659779ca0d606cd4d44408b15fa032d5e558
Author: Savalek <de...@...>
Date:   2018-07-06T13:48:39Z

    [ZEPPELIN-3567] fix InterpreterContext convert(...) method

----


---

[GitHub] zeppelin issue #3056: [ZEPPELIN-3567] fix InterpreterContext convert(...) me...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3056
  
    LGTM


---

[GitHub] zeppelin issue #3056: [ZEPPELIN-3567] fix InterpreterContext convert(...) me...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3056
  
    LGTM


---

[GitHub] zeppelin issue #3056: [ZEPPELIN-3567] fix InterpreterContext convert(...) me...

Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:

    https://github.com/apache/zeppelin/pull/3056
  
    @zjffdu, yes, this was the reason for the inoperability of the autocomplete.


---

[GitHub] zeppelin issue #3056: [ZEPPELIN-3567] fix InterpreterContext convert(...) me...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3056
  
    @Savalek But is the right jira ?  ZEPPELIN-3567


---

[GitHub] zeppelin pull request #3056: [ZEPPELIN-3567] fix InterpreterContext convert(...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3056


---