[GitHub] [incubator-mxnet] blchu opened a new pull request #16615: Faster general take

[GitBox <gi...@apache.org>]

blchu opened a new pull request #16615: Faster general take
URL: https://github.com/apache/incubator-mxnet/pull/16615
 
 
   ## Description ##
   Speeding up the take operator for the general case (when axis != 0). Speeds should now be comparable to when axis = 0, as opposed to being multiple times slower (depending on the shape of the array).
   
   ## Checklist ##
   ### Essentials ###
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Modified Take kernel to run faster
   
   ## Comments ##
   - Interesting edge cases to note: The Take kernel now assumes that when the take operator is called with axis=0, TakeGPU/TakeCPU will be used instead, and thus is now incompatible with axis=0
   - Requesting @ptrendx to review
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services