You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/12 21:30:09 UTC

[GitHub] [arrow] wesm commented on a change in pull request #7477: ARROW-4221: [C++][Python] Add canonical flag in COO sparse index

wesm commented on a change in pull request #7477:
URL: https://github.com/apache/arrow/pull/7477#discussion_r453365501



##########
File path: cpp/src/arrow/sparse_tensor.h
##########
@@ -111,22 +111,46 @@ class ARROW_EXPORT SparseCOOIndex : public internal::SparseIndexBase<SparseCOOIn
  public:
   static constexpr SparseTensorFormat::type format_id = SparseTensorFormat::COO;
 
-  /// \brief Make SparseCOOIndex from raw properties
+  /// \brief Make SparseCOOIndex from a coords tensor and canonicality

Review comment:
       It might be useful to add a definition of what "canonicality" is at the top of the class. This can be done later




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org