You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/16 22:13:26 UTC
[GitHub] [hbase-native-client] bharathv opened a new pull request #9: HBASE-24575: Cleanup the build directory structure
bharathv opened a new pull request #9:
URL: https://github.com/apache/hbase-native-client/pull/9
Switches the build layout to the following. Logically groups
all the build artifacts to make it easy to work with.
.
├── bin
├── CMakeCache.txt
├── CMakeFiles
├── cmake_install.cmake
├── CTestTestfile.cmake
├── dependencies
├── libs
├── Makefile
└── tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-native-client] phrocker commented on a change in pull request #9: HBASE-24575: Cleanup the build directory structure
Posted by GitBox <gi...@apache.org>.
phrocker commented on a change in pull request #9:
URL: https://github.com/apache/hbase-native-client/pull/9#discussion_r441460227
##########
File path: cmake/DownloadWangle.cmake
##########
@@ -20,24 +20,24 @@
## BINARY_DIR is the build directory, typically 'build'
function(download_wangle SOURCE_DIR BUILD_DIR)
-
- if (DOWNLOAD_DEPENDENCIES)
- SET (PATCH_FOLLY ${CMAKE_COMMAND} -E copy
- "${CMAKE_CURRENT_SOURCE_DIR}/cmake/folly/local/FindFolly.cmake" ${BUILD_DIR}/facebook-wangle-proj-prefix/src/facebook-wangle-proj/wangle/cmake )
- else()
- SET (PATCH_FOLLY "")
- endif()
-
- ExternalProject_Add(
- facebook-wangle-proj
- URL "https://github.com/facebook/wangle/archive/v2017.09.04.00.tar.gz"
- PATCH_COMMAND ${PATCH_FOLLY}
- INSTALL_DIR "${BUILD_DIR}/dependencies/facebook-wangle-proj-install"
- CONFIGURE_COMMAND ${CMAKE_COMMAND} -DBUILD_EXAMPLES=OFF -DCMAKE_CROSSCOMPILING=ON -DBUILD_TESTS=OFF -DFOLLY_ROOT_DIR=${FOLLY_ROOT_DIR} -DCMAKE_INSTALL_PREFIX:PATH=${BUILD_DIR}/dependencies/facebook-wangle-proj-install
- ${BUILD_DIR}/facebook-wangle-proj-prefix/src/facebook-wangle-proj/wangle # Tell CMake to use subdirectory as source.
- )
-
-
- set(WANGLE_ROOT_DIR "${BUILD_DIR}/dependencies/facebook-wangle-proj-install" CACHE STRING "" FORCE)
+ set(WANGLE_DOWNLOAD_DIR "${BUILD_DIR}/dependencies/facebook-wangle-proj-download")
Review comment:
Ah, you've mentioned the spacing before I will take note to make sure I follow this next time. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-native-client] bharathv commented on pull request #9: HBASE-24575: Cleanup the build directory structure
Posted by GitBox <gi...@apache.org>.
bharathv commented on pull request #9:
URL: https://github.com/apache/hbase-native-client/pull/9#issuecomment-645038985
@joshelser @phrocker Here is another one that makes the build directory structure and easy to work with. FYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-native-client] bharathv merged pull request #9: HBASE-24575: Cleanup the build directory structure
Posted by GitBox <gi...@apache.org>.
bharathv merged pull request #9:
URL: https://github.com/apache/hbase-native-client/pull/9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-native-client] bharathv commented on a change in pull request #9: HBASE-24575: Cleanup the build directory structure
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #9:
URL: https://github.com/apache/hbase-native-client/pull/9#discussion_r441772862
##########
File path: cmake/DownloadWangle.cmake
##########
@@ -20,24 +20,24 @@
## BINARY_DIR is the build directory, typically 'build'
function(download_wangle SOURCE_DIR BUILD_DIR)
-
- if (DOWNLOAD_DEPENDENCIES)
- SET (PATCH_FOLLY ${CMAKE_COMMAND} -E copy
- "${CMAKE_CURRENT_SOURCE_DIR}/cmake/folly/local/FindFolly.cmake" ${BUILD_DIR}/facebook-wangle-proj-prefix/src/facebook-wangle-proj/wangle/cmake )
- else()
- SET (PATCH_FOLLY "")
- endif()
-
- ExternalProject_Add(
- facebook-wangle-proj
- URL "https://github.com/facebook/wangle/archive/v2017.09.04.00.tar.gz"
- PATCH_COMMAND ${PATCH_FOLLY}
- INSTALL_DIR "${BUILD_DIR}/dependencies/facebook-wangle-proj-install"
- CONFIGURE_COMMAND ${CMAKE_COMMAND} -DBUILD_EXAMPLES=OFF -DCMAKE_CROSSCOMPILING=ON -DBUILD_TESTS=OFF -DFOLLY_ROOT_DIR=${FOLLY_ROOT_DIR} -DCMAKE_INSTALL_PREFIX:PATH=${BUILD_DIR}/dependencies/facebook-wangle-proj-install
- ${BUILD_DIR}/facebook-wangle-proj-prefix/src/facebook-wangle-proj/wangle # Tell CMake to use subdirectory as source.
- )
-
-
- set(WANGLE_ROOT_DIR "${BUILD_DIR}/dependencies/facebook-wangle-proj-install" CACHE STRING "" FORCE)
+ set(WANGLE_DOWNLOAD_DIR "${BUILD_DIR}/dependencies/facebook-wangle-proj-download")
Review comment:
No worries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org