You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Suresh Balineni <sb...@juniper.net> on 2014/01/05 01:37:28 UTC
Review Request 16642: Contrail plguin fixes for CS 4.3
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
- Contrail plugin bug fixes for CS 4.3.
- Code cleanup.
- Most of the fixes are in plugin code.
Diffs
-----
api/src/com/cloud/network/Network.java 0d916ab
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
Diff: https://reviews.apache.org/r/16642/diff/
Testing
-------
verified locally.
Thanks,
Suresh Balineni
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Suresh Balineni <sb...@juniper.net>.
> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote:
> > Ship It!
>
> Sheng Yang wrote:
> Applied to 4.3 branch. Thanks.
>
> But need a patch for master branch as well.
>
> Sheng Yang wrote:
> Reverted from 4.3 branch.
>
> It cannot compile.
Hi Sheng,
I submitted revision 2 version which has resolved compilation errors. But for some reason, it does not show my latest patch. Review tool is always always the first diff.
Let me know what is the best way to submit my patch.
- Suresh
- Suresh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31556
-----------------------------------------------------------
On Jan. 11, 2014, 12:44 a.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:44 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 0d916ab
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
>
> Diff: https://reviews.apache.org/r/16642/diff/
>
>
> Testing
> -------
>
> verified locally.
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Sheng Yang <sh...@yasker.org>.
> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote:
> > Ship It!
Applied to 4.3 branch. Thanks.
But need a patch for master branch as well.
- Sheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31556
-----------------------------------------------------------
On Jan. 7, 2014, 11:40 p.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 11:40 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 0d916ab
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
>
> Diff: https://reviews.apache.org/r/16642/diff/
>
>
> Testing
> -------
>
> verified locally.
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Sheng Yang <sh...@yasker.org>.
> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote:
> > Ship It!
>
> Sheng Yang wrote:
> Applied to 4.3 branch. Thanks.
>
> But need a patch for master branch as well.
>
> Sheng Yang wrote:
> Reverted from 4.3 branch.
>
> It cannot compile.
>
> Suresh Balineni wrote:
> Hi Sheng,
>
> I submitted revision 2 version which has resolved compilation errors. But for some reason, it does not show my latest patch. Review tool is always always the first diff.
>
> Let me know what is the best way to submit my patch.
>
> - Suresh
In fact all of your upload are the same patch...
- Sheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31556
-----------------------------------------------------------
On Jan. 11, 2014, 12:51 a.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:51 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 0d916ab
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
>
> Diff: https://reviews.apache.org/r/16642/diff/
>
>
> Testing
> -------
>
> verified locally.
>
>
> File Attachments
> ----------------
>
> Use thief patch file
> https://reviews.apache.org/media/uploaded/files/2014/01/11/ed6deb38-08b3-4ee3-bf44-68f42dd7d335__fixes.patch
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Sheng Yang <sh...@yasker.org>.
> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote:
> > Ship It!
>
> Sheng Yang wrote:
> Applied to 4.3 branch. Thanks.
>
> But need a patch for master branch as well.
Reverted from 4.3 branch.
It cannot compile.
- Sheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31556
-----------------------------------------------------------
On Jan. 7, 2014, 11:40 p.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 11:40 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 0d916ab
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
>
> Diff: https://reviews.apache.org/r/16642/diff/
>
>
> Testing
> -------
>
> verified locally.
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31556
-----------------------------------------------------------
Ship it!
Ship It!
- Sheng Yang
On Jan. 7, 2014, 11:40 p.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 11:40 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 0d916ab
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
>
> Diff: https://reviews.apache.org/r/16642/diff/
>
>
> Testing
> -------
>
> verified locally.
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Suresh Balineni <sb...@juniper.net>.
> On Jan. 11, 2014, 12:53 a.m., Sheng Yang wrote:
> > The attached file is also the same file like others.
> >
> > Please check your uploaded file.
Hi Sheng,
Its my mistake. Please use the just updated file.
- Suresh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31568
-----------------------------------------------------------
On Jan. 11, 2014, 12:59 a.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:59 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 0d916ab
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
>
> Diff: https://reviews.apache.org/r/16642/diff/
>
>
> Testing
> -------
>
> verified locally.
>
>
> File Attachments
> ----------------
>
> Good file
> https://reviews.apache.org/media/uploaded/files/2014/01/11/9ce72fe1-cb37-42c7-838b-395229b3e082__fixes.patch
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Suresh Balineni <sb...@service.juniper.net>.
Hi Sheng,
Its my mistake. I just updated review with new file fixes.patch.
Please find the attached one. This is same.
Thanks,
Suresh
From: Sheng Yang <sh...@yasker.org>>
Reply-To: Sheng Yang <sh...@yasker.org>>
Date: Friday, January 10, 2014 4:53 PM
To: Suresh Balineni <sb...@service.juniper.net>>, cloudstack <de...@cloudstack.apache.org>>, Sheng Yang <sh...@yasker.org>>
Subject: Re: Review Request 16642: Contrail plguin fixes for CS 4.3
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/
The attached file is also the same file like others.
Please check your uploaded file.
- Sheng Yang
On January 11th, 2014, 12:51 a.m. UTC, Suresh Balineni wrote:
Review request for cloudstack.
By Suresh Balineni.
Updated Jan. 11, 2014, 12:51 a.m.
Repository: cloudstack-git
Description
- Contrail plugin bug fixes for CS 4.3.
- Code cleanup.
- Most of the fixes are in plugin code.
Testing
verified locally.
Diffs
* api/src/com/cloud/network/Network.java (0d916ab)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java (dfbe7d3)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java (ca53f41)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java (b96b00c)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java (4eaafca)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java (f705f07)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java (7a77040)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java (ec37440)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java (47fc99e)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java (PRE-CREATION)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java (20b80be)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java (ec20a94)
* plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java (b4968ac)
* plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java (86750ca)
* plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java (40cd1ea)
View Diff<https://reviews.apache.org/r/16642/diff/>
File Attachments
* Use thief patch file <https://reviews.apache.org/media/uploaded/files/2014/01/11/ed6deb38-08b3-4ee3-bf44-68f42dd7d335__fixes.patch>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31568
-----------------------------------------------------------
The attached file is also the same file like others.
Please check your uploaded file.
- Sheng Yang
On Jan. 11, 2014, 12:51 a.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:51 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 0d916ab
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
>
> Diff: https://reviews.apache.org/r/16642/diff/
>
>
> Testing
> -------
>
> verified locally.
>
>
> File Attachments
> ----------------
>
> Use thief patch file
> https://reviews.apache.org/media/uploaded/files/2014/01/11/ed6deb38-08b3-4ee3-bf44-68f42dd7d335__fixes.patch
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31576
-----------------------------------------------------------
Ship it!
Looks good now. Applied to 4.3 branch.
- Sheng Yang
On Jan. 11, 2014, 12:59 a.m., Suresh Balineni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:59 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java 0d916ab
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
>
> Diff: https://reviews.apache.org/r/16642/diff/
>
>
> Testing
> -------
>
> verified locally.
>
>
> File Attachments
> ----------------
>
> Good file
> https://reviews.apache.org/media/uploaded/files/2014/01/11/9ce72fe1-cb37-42c7-838b-395229b3e082__fixes.patch
>
>
> Thanks,
>
> Suresh Balineni
>
>
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Suresh Balineni <sb...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 12:59 a.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
- Contrail plugin bug fixes for CS 4.3.
- Code cleanup.
- Most of the fixes are in plugin code.
Diffs
-----
api/src/com/cloud/network/Network.java 0d916ab
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
Diff: https://reviews.apache.org/r/16642/diff/
Testing
-------
verified locally.
File Attachments (updated)
----------------
Good file
https://reviews.apache.org/media/uploaded/files/2014/01/11/9ce72fe1-cb37-42c7-838b-395229b3e082__fixes.patch
Thanks,
Suresh Balineni
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Suresh Balineni <sb...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 12:51 a.m.)
Review request for cloudstack.
Changes
-------
Hi Sheng,
Can you please use the attached file which is "fixes.patch" ?
Thanks,
Suresh
Repository: cloudstack-git
Description
-------
- Contrail plugin bug fixes for CS 4.3.
- Code cleanup.
- Most of the fixes are in plugin code.
Diffs
-----
api/src/com/cloud/network/Network.java 0d916ab
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
Diff: https://reviews.apache.org/r/16642/diff/
Testing
-------
verified locally.
File Attachments (updated)
----------------
Use thief patch file
https://reviews.apache.org/media/uploaded/files/2014/01/11/ed6deb38-08b3-4ee3-bf44-68f42dd7d335__fixes.patch
Thanks,
Suresh Balineni
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Suresh Balineni <sb...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 12:44 a.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
- Contrail plugin bug fixes for CS 4.3.
- Code cleanup.
- Most of the fixes are in plugin code.
Diffs (updated)
-----
api/src/com/cloud/network/Network.java 0d916ab
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
Diff: https://reviews.apache.org/r/16642/diff/
Testing
-------
verified locally.
Thanks,
Suresh Balineni
Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Posted by Suresh Balineni <sb...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/
-----------------------------------------------------------
(Updated Jan. 7, 2014, 11:40 p.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
- Contrail plugin bug fixes for CS 4.3.
- Code cleanup.
- Most of the fixes are in plugin code.
Diffs (updated)
-----
api/src/com/cloud/network/Network.java 0d916ab
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea
Diff: https://reviews.apache.org/r/16642/diff/
Testing
-------
verified locally.
Thanks,
Suresh Balineni