You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/09/26 00:41:03 UTC
[kudu-CR] [mini-cluster] check for failures in TestKerberosReacquire
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14305
Change subject: [mini-cluster] check for failures in TestKerberosReacquire
......................................................................
[mini-cluster] check for failures in TestKerberosReacquire
Wrapped SmokeTestKerberizedCluster() into NO_FATALS()
in ExternalMiniClusterTest.TestKerberosReacquire scenario.
Change-Id: I2790bd461cea5caf4ba03b3487600f92362ddc89
---
M src/kudu/mini-cluster/external_mini_cluster-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/14305/1
--
To view, visit http://gerrit.cloudera.org:8080/14305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2790bd461cea5caf4ba03b3487600f92362ddc89
Gerrit-Change-Number: 14305
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini-cluster] check for failures in TestKerberosReacquire
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14305 )
Change subject: [mini-cluster] check for failures in TestKerberosReacquire
......................................................................
Patch Set 1:
> It's fine to maintain consistency, but fatal failures do get
> surfaced when a test ends, and since this function call is the last
> thing in the test, any failures in it will get properly surfaced.
That's a good point, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/14305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2790bd461cea5caf4ba03b3487600f92362ddc89
Gerrit-Change-Number: 14305
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 26 Sep 2019 05:05:03 +0000
Gerrit-HasComments: No
[kudu-CR] [mini-cluster] check for failures in TestKerberosReacquire
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [mini-cluster] check for failures in TestKerberosReacquire
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2790bd461cea5caf4ba03b3487600f92362ddc89
Gerrit-Change-Number: 14305
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [mini-cluster] check for failures in TestKerberosReacquire
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14305 )
Change subject: [mini-cluster] check for failures in TestKerberosReacquire
......................................................................
[mini-cluster] check for failures in TestKerberosReacquire
Wrapped SmokeTestKerberizedCluster() into NO_FATALS()
in ExternalMiniClusterTest.TestKerberosReacquire scenario.
Change-Id: I2790bd461cea5caf4ba03b3487600f92362ddc89
Reviewed-on: http://gerrit.cloudera.org:8080/14305
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/mini-cluster/external_mini_cluster-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2790bd461cea5caf4ba03b3487600f92362ddc89
Gerrit-Change-Number: 14305
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [mini-cluster] check for failures in TestKerberosReacquire
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14305 )
Change subject: [mini-cluster] check for failures in TestKerberosReacquire
......................................................................
Patch Set 1: Verified+1
Unrelated flake in dist-test:
failed to download task files: WARNING 164 isolateserver(1484): Adding unknown file 1d676646352
--
To view, visit http://gerrit.cloudera.org:8080/14305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2790bd461cea5caf4ba03b3487600f92362ddc89
Gerrit-Change-Number: 14305
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 26 Sep 2019 01:18:13 +0000
Gerrit-HasComments: No
[kudu-CR] [mini-cluster] check for failures in TestKerberosReacquire
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14305 )
Change subject: [mini-cluster] check for failures in TestKerberosReacquire
......................................................................
Patch Set 1: Code-Review+2
It's fine to maintain consistency, but fatal failures do get surfaced when a test ends, and since this function call is the last thing in the test, any failures in it will get properly surfaced.
--
To view, visit http://gerrit.cloudera.org:8080/14305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2790bd461cea5caf4ba03b3487600f92362ddc89
Gerrit-Change-Number: 14305
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 26 Sep 2019 05:03:29 +0000
Gerrit-HasComments: No