You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 11:29:15 UTC
[GitHub] [airflow] iw-pavan opened a new issue, #27057: Race condition in multiple triggerer process can lead to both picking up same trigger.
iw-pavan opened a new issue, #27057:
URL: https://github.com/apache/airflow/issues/27057
### Apache Airflow version
main (development)
### What happened
Currently airflow triggerer loop picks triggers to process by below steps
query_unassinged_Triggers
updated_triggers from above id
query which triggers assigned on above operation
If two triggerer process executes aboven queries unassigned trigger both will get all triggers then if one triggerer completes 2nd and 3rd operation before 2nd triggerer doest 2nd operation that will lead to both triggerer running same triggers
there is sync happening after that but unnecessary cleanup operations are done in that case.
### What you think should happen instead
There should be locking on rows which are updated.
### How to reproduce
_No response_
### Operating System
All
### Versions of Apache Airflow Providers
_No response_
### Deployment
Virtualenv installation
### Deployment details
HA setup with multiple triggerers can have this issue
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pavansharma36 commented on issue #27057: Race condition in multiple triggerer process can lead to both picking up same trigger.
Posted by GitBox <gi...@apache.org>.
pavansharma36 commented on issue #27057:
URL: https://github.com/apache/airflow/issues/27057#issuecomment-1279795311
@o-nikolas I've raised PR with fix, you can assign this to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on issue #27057: Race condition in multiple triggerer process can lead to both picking up same trigger.
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on issue #27057:
URL: https://github.com/apache/airflow/issues/27057#issuecomment-1279315570
Hey @iw-pavan! Thanks for submitting this issue :smile: I see that you've checked that you're willing to submit a PR, would you like me to assign this issue to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #27057: Race condition in multiple triggerer process can lead to both picking up same trigger.
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #27057: Race condition in multiple triggerer process can lead to both picking up same trigger.
URL: https://github.com/apache/airflow/issues/27057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org