You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by du...@apache.org on 2017/03/27 09:51:42 UTC
svn commit: r1788868 - in /sling/trunk/contrib/extensions/hapi:
client/src/test/resources/items_links.html
core/src/main/java/org/apache/sling/hapi/impl/MicrodataAttributeHelperImpl.java
Author: dulvac
Date: Mon Mar 27 09:51:42 2017
New Revision: 1788868
URL: http://svn.apache.org/viewvc?rev=1788868&view=rev
Log:
SLING-6709 The HAPI implementation doesn't provide the correct attribute type for itemscope
Modified:
sling/trunk/contrib/extensions/hapi/client/src/test/resources/items_links.html
sling/trunk/contrib/extensions/hapi/core/src/main/java/org/apache/sling/hapi/impl/MicrodataAttributeHelperImpl.java
Modified: sling/trunk/contrib/extensions/hapi/client/src/test/resources/items_links.html
URL: http://svn.apache.org/viewvc/sling/trunk/contrib/extensions/hapi/client/src/test/resources/items_links.html?rev=1788868&r1=1788867&r2=1788868&view=diff
==============================================================================
--- sling/trunk/contrib/extensions/hapi/client/src/test/resources/items_links.html (original)
+++ sling/trunk/contrib/extensions/hapi/client/src/test/resources/items_links.html Mon Mar 27 09:51:42 2017
@@ -19,11 +19,10 @@
<html>
<head>
</head>
-</html>
<body>
-<div itemscope itemtype ="http://schema.org/Movie">
+<div itemscope="" itemtype ="http://schema.org/Movie">
<h1 itemprop="name">Avatar</h1>
- <div itemprop="director" itemscope itemtype="http://schema.org/Person">
+ <div itemprop="director" itemscope="itemscope" itemtype="http://schema.org/Person">
Director: <span itemprop="name" itemscope itemtype="text">James Cameron</span>
(born <span itemprop="birthDate" itemscope itemtype="text">August 16, 1954</span>)
<p>Also directed: <a rel="test" href="/test">test</a></p>
Modified: sling/trunk/contrib/extensions/hapi/core/src/main/java/org/apache/sling/hapi/impl/MicrodataAttributeHelperImpl.java
URL: http://svn.apache.org/viewvc/sling/trunk/contrib/extensions/hapi/core/src/main/java/org/apache/sling/hapi/impl/MicrodataAttributeHelperImpl.java?rev=1788868&r1=1788867&r2=1788868&view=diff
==============================================================================
--- sling/trunk/contrib/extensions/hapi/core/src/main/java/org/apache/sling/hapi/impl/MicrodataAttributeHelperImpl.java (original)
+++ sling/trunk/contrib/extensions/hapi/core/src/main/java/org/apache/sling/hapi/impl/MicrodataAttributeHelperImpl.java Mon Mar 27 09:51:42 2017
@@ -63,8 +63,7 @@ public class MicrodataAttributeHelperImp
public Map<String, String> itemtypeMap() {
Map<String, String> attrMap = new AttrMap(2);
attrMap.put("itemtype", type.getUrl());
- attrMap.put("itemscope", String.valueOf(!type.getAllProperties().isEmpty()));
-
+ attrMap.put("itemscope", "itemscope");
return attrMap;
}