You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "coderex2522 (via GitHub)" <gi...@apache.org> on 2023/02/11 16:22:17 UTC
[GitHub] [orc] coderex2522 opened a new pull request, #1405: MINOR: Add Xin Zhang to committers page
coderex2522 opened a new pull request, #1405:
URL: https://github.com/apache/orc/pull/1405
### What changes were proposed in this pull request?
This PR aims to add Xin Zhang to the committers page.
### Why are the changes needed?
To keep the list of committers for the ORC website up to date.
### How was this patch tested?
Manually review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1405: MINOR: Add Xin Zhang to committers page
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1405:
URL: https://github.com/apache/orc/pull/1405#issuecomment-1427246564
Do you mean `News`, @wgtmac ?
> @dongjoon-hyun Should I add a welcome page as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #1405: MINOR: Add Xin Zhang to committers page
Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun commented on PR #1405:
URL: https://github.com/apache/orc/pull/1405#issuecomment-1427250449
@wgtmac
Yes, please add an entry to `News` welcoming Xin as a new committer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1405: MINOR: Add Xin Zhang to committers page
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1405:
URL: https://github.com/apache/orc/pull/1405#issuecomment-1427230845
@dongjoon-hyun Should I add a welcome page as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1405: MINOR: Add Xin Zhang to committers page
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1405:
URL: https://github.com/apache/orc/pull/1405#discussion_r1103768025
##########
site/develop/committers.md:
##########
@@ -51,6 +51,7 @@ Vaibhav Gumashta | vgumashta | Committer
Wei Zheng | weiz | Committer
William Hyun | william | PMC Chair
Xiening Dai | xndai | Committer
+Xin Zhang | xinzhang | Committer
Review Comment:
Thank you. Please sort by Apache ID as mentioned here, @coderex2522 .
https://github.com/apache/orc/blob/e674d8a61d77d0e477c5251f5091b07e1c3c1d3e/site/develop/committers.md#L9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1405: MINOR: Add Xin Zhang to committers page
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1405:
URL: https://github.com/apache/orc/pull/1405#discussion_r1103768025
##########
site/develop/committers.md:
##########
@@ -51,6 +51,7 @@ Vaibhav Gumashta | vgumashta | Committer
Wei Zheng | weiz | Committer
William Hyun | william | PMC Chair
Xiening Dai | xndai | Committer
+Xin Zhang | xinzhang | Committer
Review Comment:
Thank you. Please sort by Apache ID instead of `Name` as mentioned here, @coderex2522 .
https://github.com/apache/orc/blob/e674d8a61d77d0e477c5251f5091b07e1c3c1d3e/site/develop/committers.md#L9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun merged pull request #1405: MINOR: Add Xin Zhang to committers page
Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun merged PR #1405:
URL: https://github.com/apache/orc/pull/1405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org