You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2021/04/11 16:42:50 UTC

[maven-release] branch master updated: [MRELEASE-1016] use explicit parameter in message, fix branch message

This is an automated email from the ASF dual-hosted git repository.

rfscholte pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-release.git


The following commit(s) were added to refs/heads/master by this push:
     new 402b093  [MRELEASE-1016] use explicit parameter in message, fix branch message
402b093 is described below

commit 402b093374fdeee1a3daa8163aec96389581d861
Author: rfscholte <rf...@apache.org>
AuthorDate: Sun Apr 11 18:42:21 2021 +0200

    [MRELEASE-1016] use explicit parameter in message, fix branch message
---
 .../maven/shared/release/phase/ScmBranchPhase.java       |  5 ++---
 .../shared/release/phase/ScmCommitPreparationPhase.java  | 16 +++++++++++++---
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmBranchPhase.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmBranchPhase.java
index 576f511..a3243e4 100644
--- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmBranchPhase.java
+++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmBranchPhase.java
@@ -67,12 +67,11 @@ public class ScmBranchPhase
 
         validateConfiguration( releaseDescriptor );
 
+        logInfo( relResult, "Branching release with the label " + releaseDescriptor.getScmReleaseLabel() + "..." );
+
         ReleaseDescriptor basedirAlignedReleaseDescriptor =
             ReleaseUtil.createBasedirAlignedReleaseDescriptor( releaseDescriptor, reactorProjects );
 
-        logInfo( relResult, "Branching release with the label " + basedirAlignedReleaseDescriptor.getScmReleaseLabel()
-            + "..." );
-
         ScmRepository repository;
         ScmProvider provider;
         try
diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmCommitPreparationPhase.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmCommitPreparationPhase.java
index b1f47e8..b4a5bbf 100644
--- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmCommitPreparationPhase.java
+++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmCommitPreparationPhase.java
@@ -46,15 +46,25 @@ public class ScmCommitPreparationPhase
         // no prepare-commit required
         if ( releaseDescriptor.isSuppressCommitBeforeTagOrBranch() )
         {
+            String parameterName;
+            if ( releaseDescriptor.isBranchCreation() ) 
+            {
+                parameterName = "suppressCommitBeforeBranch";
+            }
+            else 
+            {
+                parameterName = "suppressCommitBeforeTag";
+            }
+
             if ( simulating )
             {
-                logInfo( result, "Full run would not commit changes, "
-                    + "because suppressCommitBeforeTagOrBranch is set to true." );
+                logInfo( result,
+                         "Full run would not commit changes, " + "because " + parameterName + " is set to true." );
             }
             else
             {
                 logInfo( result,
-                         "Modified POMs are not committed because suppressCommitBeforeTagOrBranch is set to true." );
+                         "Modified POMs are not committed because " + parameterName + " is set to true." );
             }
         }
         // commit development versions required