You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2016/04/26 10:56:26 UTC
Review Request 46675: RANGER-953 : Tag Based policies menu is not
appearing for 'ADMIN' role users after upgrade from 0.5
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46675/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-953
https://issues.apache.org/jira/browse/RANGER-953
Repository: ranger
Description
-------
**Problem Statement :** If user is upgrading Ranger from 0.5 to 0.6 and if Permission model patch 'PatchPersmissionModel_J10003' has already been executed during Ranger 0.5 installation, then during Ranger 0.6 installation 'PatchPersmissionModel_J10003' will not be executed and no user will have permission on 'Tag Based Policies'.
**Proposed Solution :**
Added a java patch to add permissions; which will be executed during ranger installation.
This java patch will add permissions on Tag Based Policies module for all 'Admin' role users.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 571947c
security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePersmission_J10005.java PRE-CREATION
Diff: https://reviews.apache.org/r/46675/diff/
Testing
-------
**Steps performed(with patch) :**
1. Installed Ranger from 0.5 branch version and started ranger-admin.
2. Logged into Ranger admin, logged out and stopped Ranger-admin.
3. Created Build from master branch version and configured ranger db properties provided in step-1 installation.
4. Installed Ranger-admin and 'PatchTagModulePersmission_J10005' was applied successfully.
5. Started Ranger admin and logged into Ranger admin from 'admin' user to see whether 'Tag Based Policies' menu is visible or not.
**Expected Behaviour :**
1. 'Tag Based Policies' menu should be visible.
2. In Permission page all users with 'Admin' role should have access to 'Tag Based Policies' module.
**Actual Behavior :**
1. 'Tag Based Policies' menu was visible to 'admin' user
2. In Permission page all users with 'Admin' role was having access to 'Tag Based Policies' module.
Thanks,
Pradeep Agrawal
Re: Review Request 46675: RANGER-953 : Tag Based policies menu is not
appearing for 'ADMIN' role users after upgrade from 0.5
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46675/#review130631
-----------------------------------------------------------
Fix it, then Ship it!
security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePersmission_J10005.java (line 92)
<https://reviews.apache.org/r/46675/#comment194445>
Consider the following log message:
"Added '" + xModDef.getModule() + "' permission to user '" + xPortalUser.getLoginId() + "'"
- Madhan Neethiraj
On April 26, 2016, 8:56 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46675/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 8:56 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-953
> https://issues.apache.org/jira/browse/RANGER-953
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement :** If user is upgrading Ranger from 0.5 to 0.6 and if Permission model patch 'PatchPersmissionModel_J10003' has already been executed during Ranger 0.5 installation, then during Ranger 0.6 installation 'PatchPersmissionModel_J10003' will not be executed and no user will have permission on 'Tag Based Policies'.
>
> **Proposed Solution :**
> Added a java patch to add permissions; which will be executed during ranger installation.
> This java patch will add permissions on Tag Based Policies module for all 'Admin' role users.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 571947c
> security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePersmission_J10005.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46675/diff/
>
>
> Testing
> -------
>
> **Steps performed(with patch) :**
> 1. Installed Ranger from 0.5 branch version and started ranger-admin.
> 2. Logged into Ranger admin, logged out and stopped Ranger-admin.
> 3. Created Build from master branch version and configured ranger db properties provided in step-1 installation.
> 4. Installed Ranger-admin and 'PatchTagModulePersmission_J10005' was applied successfully.
> 5. Started Ranger admin and logged into Ranger admin from 'admin' user to see whether 'Tag Based Policies' menu is visible or not.
>
> **Expected Behaviour :**
> 1. 'Tag Based Policies' menu should be visible.
> 2. In Permission page all users with 'Admin' role should have access to 'Tag Based Policies' module.
>
> **Actual Behavior :**
> 1. 'Tag Based Policies' menu was visible to 'admin' user
> 2. In Permission page all users with 'Admin' role was having access to 'Tag Based Policies' module.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 46675: RANGER-953 : Tag Based policies menu is not
appearing for 'ADMIN' role users after upgrade from 0.5
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46675/#review130882
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 28, 2016, 3:22 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46675/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 3:22 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-953
> https://issues.apache.org/jira/browse/RANGER-953
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement :** If user is upgrading Ranger from 0.5 to 0.6 and if Permission model patch 'PatchPersmissionModel_J10003' has already been executed during Ranger 0.5 installation, then during Ranger 0.6 installation 'PatchPersmissionModel_J10003' will not be executed and no user will have permission on 'Tag Based Policies'.
>
> **Proposed Solution :**
> Added a java patch to add permissions; which will be executed during ranger installation.
> This java patch will add permissions on Tag Based Policies module for all 'Admin' role users.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 571947c
> security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePersmission_J10005.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46675/diff/
>
>
> Testing
> -------
>
> **Steps performed(with patch) :**
> 1. Installed Ranger from 0.5 branch version and started ranger-admin.
> 2. Logged into Ranger admin, logged out and stopped Ranger-admin.
> 3. Created Build from master branch version and configured ranger db properties provided in step-1 installation.
> 4. Installed Ranger-admin and 'PatchTagModulePersmission_J10005' was applied successfully.
> 5. Started Ranger admin and logged into Ranger admin from 'admin' user to see whether 'Tag Based Policies' menu is visible or not.
>
> **Expected Behaviour :**
> 1. 'Tag Based Policies' menu should be visible.
> 2. In Permission page all users with 'Admin' role should have access to 'Tag Based Policies' module.
>
> **Actual Behavior :**
> 1. 'Tag Based Policies' menu was visible to 'admin' user
> 2. In Permission page all users with 'Admin' role was having access to 'Tag Based Policies' module.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 46675: RANGER-953 : Tag Based policies menu is not
appearing for 'ADMIN' role users after upgrade from 0.5
Posted by Pradeep Agrawal <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46675/
-----------------------------------------------------------
(Updated April 28, 2016, 3:22 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Changed log message as per review comments
Bugs: RANGER-953
https://issues.apache.org/jira/browse/RANGER-953
Repository: ranger
Description
-------
**Problem Statement :** If user is upgrading Ranger from 0.5 to 0.6 and if Permission model patch 'PatchPersmissionModel_J10003' has already been executed during Ranger 0.5 installation, then during Ranger 0.6 installation 'PatchPersmissionModel_J10003' will not be executed and no user will have permission on 'Tag Based Policies'.
**Proposed Solution :**
Added a java patch to add permissions; which will be executed during ranger installation.
This java patch will add permissions on Tag Based Policies module for all 'Admin' role users.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 571947c
security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePersmission_J10005.java PRE-CREATION
Diff: https://reviews.apache.org/r/46675/diff/
Testing
-------
**Steps performed(with patch) :**
1. Installed Ranger from 0.5 branch version and started ranger-admin.
2. Logged into Ranger admin, logged out and stopped Ranger-admin.
3. Created Build from master branch version and configured ranger db properties provided in step-1 installation.
4. Installed Ranger-admin and 'PatchTagModulePersmission_J10005' was applied successfully.
5. Started Ranger admin and logged into Ranger admin from 'admin' user to see whether 'Tag Based Policies' menu is visible or not.
**Expected Behaviour :**
1. 'Tag Based Policies' menu should be visible.
2. In Permission page all users with 'Admin' role should have access to 'Tag Based Policies' module.
**Actual Behavior :**
1. 'Tag Based Policies' menu was visible to 'admin' user
2. In Permission page all users with 'Admin' role was having access to 'Tag Based Policies' module.
Thanks,
Pradeep Agrawal