[jira] [Commented] (HBASE-15978) Netty API leaked into public API

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318849#comment-15318849 ] 

stack commented on HBASE-15978:
-------------------------------

[~ndimiduk] The netty Future is wrapped in an HBase one insulating us from netty change, no?

It came in here:

commit fa033b6a08020282004ec87353f743fc205140ef
Author: Jurriaan Mous <ju...@jurmo.us>
Date:   Sat May 7 12:46:58 2016 +0200

    HBASE-15793 Port over AsyncCall improvements
    Signed-off-by: stack <st...@apache.org>


[~jurmous] FYI

> Netty API leaked into public API
> --------------------------------
>
>                 Key: HBASE-15978
>                 URL: https://issues.apache.org/jira/browse/HBASE-15978
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Nick Dimiduk
>            Priority: Critical
>
> Noticed out public {{[client.Future|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Future.html]}} interface extends Netty, which means our public API is bound to a specific Netty API and release. IIRC we were minimizing our public-facing surface area and asserting ownership over the whole of it so as to control our compatibility. Ie, we've done this with Protobuf as well. Not sure if this has made it back to other branches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)