You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2026/08/30 06:41:14 UTC
[PR] WW-5706 Align RestfulActionMapper action name handling with DefaultActionMapper (6.x) [struts]
lukaszlenart opened a new pull request, #1881:
URL: https://github.com/apache/struts/pull/1881
6.x backport of #1880.
`RestfulActionMapper` derived the action name directly from the request URI, whereas `DefaultActionMapper` normalizes and validates it through `cleanupActionName` against the `allowedActionNames` pattern. This change applies the same validation in `RestfulActionMapper` (honouring the `struts.allowed.action.names` and `struts.default.action.name` settings) so both mappers handle action names consistently. When the extracted name does not match the allowed pattern, the configured default action name is used and a warning is logged.
`Restful2ActionMapper` already extends `DefaultActionMapper` and inherits this behaviour, so no change is needed there.
Added regression tests covering both a rejected and an accepted action name.
Fixes [WW-5706](https://issues.apache.org/jira/browse/WW-5706)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5706 Align RestfulActionMapper action name handling with DefaultActionMapper (6.x) [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #1881:
URL: https://github.com/apache/struts/pull/1881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5706 Align RestfulActionMapper action name handling with DefaultActionMapper (6.x) [struts]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1881:
URL: https://github.com/apache/struts/pull/1881#issuecomment-5467231433
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1881) **Quality Gate failed**
Failed conditions
 [69.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1881&metric=new_coverage&view=list) (required ≥ 80%)
<!-- sqra:qg_revision=0630ddece24c75d0389f2d937de143b6d30c55c18d4edbf3bb894ddfd6520e81 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1881)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org