You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/01 09:51:09 UTC

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #5037: Data source initialization twice results in metadata initialization twice.

yu199195 opened a new pull request #5037: Data source initialization twice results in metadata initialization twice.
URL: https://github.com/apache/incubator-shardingsphere/pull/5037
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on issue #5037: Data source initialization twice results in metadata initialization twice.

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5037: Data source initialization twice results in metadata initialization twice.
URL: https://github.com/apache/incubator-shardingsphere/pull/5037#issuecomment-607173468
 
 
   fix ci first

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on issue #5037: Data source initialization twice results in metadata initialization twice.

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5037: Data source initialization twice results in metadata initialization twice.
URL: https://github.com/apache/incubator-shardingsphere/pull/5037#issuecomment-607182122
 
 
   /ci
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5037: Data source initialization twice results in metadata initialization twice.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5037: Data source initialization twice results in metadata initialization twice.
URL: https://github.com/apache/incubator-shardingsphere/pull/5037#issuecomment-607194982
 
 
   ## Pull Request Test Coverage Report for [Build 2320](https://coveralls.io/builds/29766469)
   
   * **5** of **6**   **(83.33%)**  changed or added relevant lines in **5** files are covered.
   * **80** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.006%**) to **57.172%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/OrchestrationMasterSlaveDataSourceFactory.java](https://coveralls.io/builds/29766469/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2FOrchestrationMasterSlaveDataSourceFactory.java#L54) | 0 | 1 | 0.0%
   <!-- | **Total:** | **5** | **6** | **83.33%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/constant/MySQLBinlogEventType.java](https://coveralls.io/builds/29766469/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fconstant%2FMySQLBinlogEventType.java#L127) | 1 | 97.73% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29766469/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29766469/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L51) | 11 | 0% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29766469/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L81) | 24 | 0% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/29766469/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L84) | 42 | 0% |
   <!-- | **Total:** | **80** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29766469/badge)](https://coveralls.io/builds/29766469) |
   | :-- | --: |
   | Change from base [Build 10764](https://coveralls.io/builds/29759718): |  -0.006% |
   | Covered Lines: | 11671 |
   | Relevant Lines: | 20414 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5037: Data source initialization twice results in metadata initialization twice.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5037: Data source initialization twice results in metadata initialization twice.
URL: https://github.com/apache/incubator-shardingsphere/pull/5037#issuecomment-607194982
 
 
   ## Pull Request Test Coverage Report for [Build 10771](https://coveralls.io/builds/29766633)
   
   * **5** of **6**   **(83.33%)**  changed or added relevant lines in **5** files are covered.
   * **78** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.01%**) to **57.167%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/OrchestrationMasterSlaveDataSourceFactory.java](https://coveralls.io/builds/29766633/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2FOrchestrationMasterSlaveDataSourceFactory.java#L54) | 0 | 1 | 0.0%
   <!-- | **Total:** | **5** | **6** | **83.33%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/constant/MySQLBinlogEventType.java](https://coveralls.io/builds/29766633/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fconstant%2FMySQLBinlogEventType.java#L127) | 1 | 97.73% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29766633/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L51) | 11 | 0% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29766633/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L81) | 24 | 0% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/29766633/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L84) | 42 | 0% |
   <!-- | **Total:** | **78** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29766633/badge)](https://coveralls.io/builds/29766633) |
   | :-- | --: |
   | Change from base [Build 10764](https://coveralls.io/builds/29759718): |  -0.01% |
   | Covered Lines: | 11670 |
   | Relevant Lines: | 20414 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #5037: Data source initialization twice results in metadata initialization twice.

Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #5037: Data source initialization twice results in metadata initialization twice.
URL: https://github.com/apache/incubator-shardingsphere/pull/5037
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services