You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Mike Adamson (JIRA)" <ji...@apache.org> on 2015/05/15 11:48:00 UTC
[jira] [Comment Edited] (CASSANDRA-9381)
AbstractColumnFamilyInputFormat is incorrectly interpreting token values
when building ColumnFamilySplit
[ https://issues.apache.org/jira/browse/CASSANDRA-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545230#comment-14545230 ]
Mike Adamson edited comment on CASSANDRA-9381 at 5/15/15 9:47 AM:
------------------------------------------------------------------
+1
was (Author: mike_tr_adamson):
+1 - passed my tests
> AbstractColumnFamilyInputFormat is incorrectly interpreting token values when building ColumnFamilySplit
> --------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-9381
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9381
> Project: Cassandra
> Issue Type: Bug
> Components: Hadoop
> Reporter: Mike Adamson
> Assignee: Philip Thompson
> Fix For: 2.2.x
>
> Attachments: 9381-1.txt
>
>
> The SplitCallable.call method in AbstractColumnFamilyInputFormat has the following code for building ColumnFamilySplits:
> {noformat}
> for (TokenRange subSplit : subSplits.keySet())
> {
> List<TokenRange> ranges = subSplit.unwrap();
> for (TokenRange subrange : ranges)
> {
> ColumnFamilySplit split =
> new ColumnFamilySplit(
> subrange.getStart().toString().substring(2),
> subrange.getEnd().toString().substring(2),
> subSplits.get(subSplit),
> endpoints);
> logger.debug("adding {}", split);
> splits.add(split);
> }
> }
> {noformat}
> The subrange.getStart().toString().substring(2) works for the OrderPreservingPartitioner because the toString for the OPPToken in the java driver returns a hex value preceded by 0x. It doesn't work for the Murmur3Partitioner because the toString for the M3PToken returns Long.toString.
> As a result the tokens lose their first 2 digits.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)