You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Babrou <ib...@gmail.com> on 2015/11/20 18:00:35 UTC
Review Request 40487: MESOS-3959: show slave hostname on executor page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
MESOS-3959: show slave hostname on executor page
Diffs
-----
src/webui/master/static/slave_executor.html 7c66405090f46f89bdd29806a58c05dc76c0ad23
Diff: https://reviews.apache.org/r/40487/diff/
Testing
-------
Thanks,
Ian Babrou
Re: Review Request 40487: MESOS-3959: show slave hostname on executor
page
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/#review112453
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Nov. 20, 2015, 5 p.m., Ian Babrou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40487/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 5 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3959: show slave hostname on executor page
>
>
> Diffs
> -----
>
> src/webui/master/static/slave_executor.html 7c66405090f46f89bdd29806a58c05dc76c0ad23
>
> Diff: https://reviews.apache.org/r/40487/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Babrou
>
>
Re: Review Request 40487: MESOS-3959: show slave hostname on executor
page
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/#review108774
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On Nov. 20, 2015, 5 p.m., Ian Babrou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40487/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 5 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3959: show slave hostname on executor page
>
>
> Diffs
> -----
>
> src/webui/master/static/slave_executor.html 7c66405090f46f89bdd29806a58c05dc76c0ad23
>
> Diff: https://reviews.apache.org/r/40487/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Babrou
>
>
Re: Review Request 40487: MESOS-3959: show slave hostname on executor
page
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/#review108765
-----------------------------------------------------------
Hey Ian thanks for your patch!
While this is pretty trivial, would you mind sharing a screenshot before I commit this so that I know you've actually checked how this looks?
- Ben Mahler
On Nov. 20, 2015, 5 p.m., Ian Babrou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40487/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 5 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3959: show slave hostname on executor page
>
>
> Diffs
> -----
>
> src/webui/master/static/slave_executor.html 7c66405090f46f89bdd29806a58c05dc76c0ad23
>
> Diff: https://reviews.apache.org/r/40487/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Babrou
>
>