You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2015/07/20 11:56:57 UTC
[GitHub] couchdb-fauxton pull request: Trigger error on failed session
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/482
Trigger error on failed session
If a session fetch fails then fire an event
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton trigger-error-on-session
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/482.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #482
----
commit 06e9d4156a63ec7aff539bc7642c76caa8934599
Author: Garren Smith <ga...@gmail.com>
Date: 2015-07-20T09:55:51Z
Trigger error on failed session
If a session fetch fails then fire an event
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Trigger error on failed session
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Trigger error on failed session
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/482#issuecomment-122945030
idea: before we kick of [this test](https://github.com/apache/couchdb-fauxton/blob/master/app/addons/verifyinstall/resources.js#L138-158) in the "verify your couchdb installation" we poll if the replication is finished
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Trigger error on failed session
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/482#discussion_r35002314
--- Diff: app/core/couchdbSession.js ---
@@ -58,6 +58,8 @@ function (FauxtonAPI) {
// this will return the user as a value to all function that calls done on this
// eg. session.fetchUser().done(user) { .. do something with user ..}
return user;
+ }, function (session, xhr, type, message) {
+ that.trigger('session:error', xhr, type, message);
});
--- End diff --
we use bind
```js
function (session, xhr, type, message) {
this.trigger('session:error', xhr, type, message);
}.bind(this));
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Trigger error on failed session
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/482#issuecomment-122944219
hmm no idea how to fix it: in this travis run the test for replication really failed. the validation test seems to be broken by design as it just sets up a replication in a fire and forget style. this means the validation can happen and the replication is not finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Trigger error on failed session
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/482#issuecomment-123405693
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Trigger error on failed session
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/482#issuecomment-122940240
+1 can you kick off travis again?
i will try to fix the flaky test in the meantime
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---