[GitHub] [spark] dongjoon-hyun commented on pull request #40690: [SPARK-43043][CORE] Improve the performance of MapOutputTracker.updateMapOutput

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on PR #40690:
URL: https://github.com/apache/spark/pull/40690#issuecomment-1661395670

   Hi, @jiangxb1987 and all. It seems that we found a bug at Apache Spark 3.4.1. The following test code shows a regression.
   
   If you don't mind, shall we revert this improvement PR from `branch-3.4` while keeping it `master` and `branch-3.5`?
   
   ```scala
     test("SPARK-XXX: getMapOutputLocation should not throw NPE") {
       val tracker = newTrackerMaster()
       try {
         tracker.registerShuffle(0, 1, 1)
         tracker.registerMapOutput(0, 0, MapStatus(BlockManagerId("exec-1", "hostA", 1000),
           Array(2L), 0))
         tracker.removeOutputsOnHost("hostA")
         assert(tracker.getMapOutputLocation(0, 0) == None)
       } finally {
         tracker.stop()
       }
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org