[GitHub] [hbase] ramkrish86 commented on a change in pull request #939: HBASE-23349 : Notify readers if archival of compacted store files is stuck due to scanners

[GitBox <gi...@apache.org>]

ramkrish86 commented on a change in pull request #939: HBASE-23349 : Notify readers if archival of compacted store files is stuck due to scanners
URL: https://github.com/apache/hbase/pull/939#discussion_r358166155
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChangedReadersObserver.java
 ##########
 @@ -40,5 +40,16 @@
    * @param memStoreScanners scanner of current memstore
    * @throws IOException e
    */
-  void updateReaders(List<HStoreFile> sfs, List<KeyValueScanner> memStoreScanners) throws IOException;
+  void updateReaders(List<HStoreFile> sfs, List<KeyValueScanner> memStoreScanners)
+    throws IOException;
+
+  /**
+   * Notify observers to close all scanners and re-create them from given list of store files -
+   * should be non-compacted store files
+   *
+   * @param storeFiles non compacted store files to re-create scanners from
+   * @throws IOException if something goes wrong while dealing with store scanners
+   */
+  void updateReaders(List<HStoreFile> storeFiles) throws IOException;
 
 Review comment:
   Just the same API is enough for us ? We can pass an empty list for memstoreScanners ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services