You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/11/25 15:40:58 UTC

[jira] [Created] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

Robbie Gemmell created QPID-4469:
------------------------------------

             Summary: [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()
                 Key: QPID-4469
                 URL: https://issues.apache.org/jira/browse/QPID-4469
             Project: Qpid
          Issue Type: Improvement
          Components: Java Client, Java Common
    Affects Versions: 0.18, 0.16, 0.14
            Reporter: Robbie Gemmell
            Assignee: Robbie Gemmell
             Fix For: 0.21


OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Resolved] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell resolved QPID-4469.
----------------------------------

    Resolution: Fixed

Now merged to the 0.20 release branch.
                
> [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()
> ----------------------------------------------------------------------------------------
>
>                 Key: QPID-4469
>                 URL: https://issues.apache.org/jira/browse/QPID-4469
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client, Java Common
>    Affects Versions: 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Rob Godfrey
>             Fix For: 0.20, 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505403#comment-13505403 ] 

Justin Ross commented on QPID-4469:
-----------------------------------

Though not in itself a priority change for 0.20, it sensibly goes along with QPID-4468.  Reviewed by Rob.  Approved for 0.20.
                
> [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()
> ----------------------------------------------------------------------------------------
>
>                 Key: QPID-4469
>                 URL: https://issues.apache.org/jira/browse/QPID-4469
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client, Java Common
>    Affects Versions: 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Rob Godfrey
>             Fix For: 0.20, 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Assigned] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-4469:
------------------------------------

    Assignee: Rob Godfrey  (was: Robbie Gemmell)

Rob reviewed this together with the changes for QPID-4468 (and 'thanked' me via email me for conflicting heavily with his changes for QPID-2796 :P)
                
> [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()
> ----------------------------------------------------------------------------------------
>
>                 Key: QPID-4469
>                 URL: https://issues.apache.org/jira/browse/QPID-4469
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client, Java Common
>    Affects Versions: 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Rob Godfrey
>             Fix For: 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-4469:
---------------------------------

    Status: Ready To Review  (was: In Progress)
    
> [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()
> ----------------------------------------------------------------------------------------
>
>                 Key: QPID-4469
>                 URL: https://issues.apache.org/jira/browse/QPID-4469
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client, Java Common
>    Affects Versions: 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503504#comment-13503504 ] 

Robbie Gemmell commented on QPID-4469:
--------------------------------------

Change made in http://svn.apache.org/viewvc?rev=1413363&view=rev
                
> [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()
> ----------------------------------------------------------------------------------------
>
>                 Key: QPID-4469
>                 URL: https://issues.apache.org/jira/browse/QPID-4469
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client, Java Common
>    Affects Versions: 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Justin Ross updated QPID-4469:
------------------------------

    Fix Version/s: 0.20
    
> [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()
> ----------------------------------------------------------------------------------------
>
>                 Key: QPID-4469
>                 URL: https://issues.apache.org/jira/browse/QPID-4469
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client, Java Common
>    Affects Versions: 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Rob Godfrey
>             Fix For: 0.20, 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is unused by the transport implementations because SSL is implemented in the client as a wrapper over the transport. The 0-10 path of the client supplies null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org