You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Will Jones (Jira)" <ji...@apache.org> on 2022/03/18 22:37:00 UTC
[jira] [Created] (ARROW-15975) [C++] Document VisitArrayInline and type traits
Will Jones created ARROW-15975:
----------------------------------
Summary: [C++] Document VisitArrayInline and type traits
Key: ARROW-15975
URL: https://issues.apache.org/jira/browse/ARROW-15975
Project: Apache Arrow
Issue Type: Improvement
Components: C++
Affects Versions: 7.0.0
Reporter: Will Jones
Assignee: Will Jones
Fix For: 8.0.0
In ARROW-15952, we documented the {{ArrayVisitor}} and {{TypeVisitor}} classes. But as I discovered in [a cookbook PR|https://github.com/apache/arrow-cookbook/pull/166], you can't subclass these abstract visitors _and_ use type traits. Now I know why most visitor implementations within of Arrow don't subclasses these.
We should instead suggest users simply use the {{VisitArrayInline}} and {{VisitTypeInline}} with their visitors, and ignore the {{ArrayVisitor}} and {{TypeVisitor}} classes and associated {{Accept()}} methods. In fact, can we deprecate (or even remove) those? Do they add anything valuable?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)