You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/10/08 23:12:04 UTC
[GitHub] [netbeans] mbien opened a new pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
mbien opened a new pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227
fixes https://issues.apache.org/jira/browse/NETBEANS-6111
auto completion for "record" didn't take already typed prefixes into account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-951163882
@neilcsmith-net @jlahoda in case there would be another RC, this bugfix could be considered too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-951587080
FWIW, `ServerTest` failed in the last run, restarted and will see if that repeats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-952244860
Thanks @neilcsmith-net , yes the failure in SdkSuiteTest is currently under investigation (AFAIK).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-948388815
@jlahoda roger, the two .pass files are back in the 1.8 folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-952246972
thanks @jlahoda + @neilcsmith-net for the last minute integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-947342860
Looks good, but it would be nice to have a test (e.g. `java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask114FeaturesTest.java`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-948050568
@jlahoda done, updated the test + I moved the two .pass files around since i believe they are meant to be in the folder for 14 and not 1.8.
Pinging @matthiasblaesing, maybe we can get this fix for a (fairly annoying) bug in too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-951176606
Rebased on delivery. @jlahoda can you check and merge if you're happy.
@mbien if in by tomorrow it will be in RC1, and there will probably be 2 or 3 more before voting candidate going on previous releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-939189041
"ValidateLayerConsistencyTest" failed. Seems to be unrelated to the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-952115565
Still a test failure in that bunch, but not in `ServerTest` on last run as far as I can tell. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-949858930
feature freeze happened. If someone still wants to integrate this bugfix, feel free to change the target branch to delivery before pressing the button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #3227: [NETBEANS-6111] auto completion for "record" is now prefix aware.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #3227:
URL: https://github.com/apache/netbeans/pull/3227#issuecomment-948281949
Thanks for the test, but please return the golden files to the 1.8 folder - the golden files are based on the runtime platform, not on the source level (as e.g. the content of `java.lang` differs across JDK versions). It is a bit confusing to run JDK 14+ language feature tests on JDK 8, but without that, we would have no coverage of these features on 8-13. (The tests runs with nb-javac on JDK 8, so the javac can understand records, just the runtime has a different content of things like `java.lang`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists