You are viewing a plain text version of this content. The canonical link for it is here.

Posted to scm@geronimo.apache.org by jd...@apache.org on 2006/07/11 20:45:02 UTC

svn commit: r420946 - /geronimo/sandbox/svkmerge/m2migration/m2-plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/PackageBuilderShellMojo.java

Author: jdillon
Date: Tue Jul 11 11:45:01 2006
New Revision: 420946

URL: http://svn.apache.org/viewvc?rev=420946&view=rev
Log:
Added comment about classloader

Modified:
    geronimo/sandbox/svkmerge/m2migration/m2-plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/PackageBuilderShellMojo.java

Modified: geronimo/sandbox/svkmerge/m2migration/m2-plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/PackageBuilderShellMojo.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/svkmerge/m2migration/m2-plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/PackageBuilderShellMojo.java?rev=420946&r1=420945&r2=420946&view=diff
==============================================================================
--- geronimo/sandbox/svkmerge/m2migration/m2-plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/PackageBuilderShellMojo.java (original)
+++ geronimo/sandbox/svkmerge/m2migration/m2-plugins/geronimo-packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/PackageBuilderShellMojo.java Tue Jul 11 11:45:01 2006
@@ -215,6 +215,12 @@
     public void executePackageBuilderShell() throws Exception {
         PackageBuilder builder = new PackageBuilder();
 
+        //
+        // NOTE: May need to run this in a controlled classloader (w/reflection or a proxy)
+        //
+        //       http://www.nabble.com/PackageBuilderShellMojo-%28m2%29-and-classloaders-p5271991.html
+        //
+
         builder.setClassPath(classPath);
         builder.setDeployerName(deployerName);
         builder.setDeploymentConfig(deploymentConfigs);