[jira] [Commented] (CASSANDRA-11503) Need a tool to detect what percentage of SSTables on a node have been repaired when using incremental repairs.

["Yuki Morishita (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-11503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269026#comment-15269026 ] 

Yuki Morishita commented on CASSANDRA-11503:
--------------------------------------------

Thanks for the patch Chris!

Adding RepairMetrics is nice idea, though isn't it useful to have repaired% per table rather than accumulating repaired% accross all tables?
If so, maybe moving repaired% to TableMetrics is better, and we can show it through {{nodetool tablestats}}.

For the code, I prefer moving {{RepairMetrics}} to {{ActiveRepairService}} and passing it to {{RepairSession}} constructor, so we don't have to access {{StorageService.instance}} singleton.

> Need a tool to detect what percentage of SSTables on a node have been repaired when using incremental repairs.
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11503
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11503
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Sean Usher
>            Assignee: Chris Lohfink
>            Priority: Minor
>         Attachments: CASSANDRA-11503.patch
>
>
> When using incremental repair, we should be able to look at SSTables and understand how many sstables are in the repaired and unrepaired buckets on each machine. This can help us track the repair progress and if we are hitting any issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)