You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Pavitra Subramaniam (JIRA)" <ad...@incubator.apache.org> on 2006/10/18 18:01:35 UTC

[jira] Created: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
---------------------------------------------------------------------------------------------------

                 Key: ADFFACES-244
                 URL: http://issues.apache.org/jira/browse/ADFFACES-244
             Project: MyFaces ADF-Faces
          Issue Type: Improvement
            Reporter: Pavitra Subramaniam
            Priority: Minor


The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
 
1. Remove the'disabled' property 
2. Rename the 'readOnly' property to 'disabled'  



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Posted by "Pavitra Subramaniam (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-244?page=all ]

Pavitra Subramaniam updated ADFFACES-244:
-----------------------------------------

    Attachment: Issue244.patch

Attached a Subversion patch file.
- The fixes remove the attribute readOnly. No changes have been made to the skin selectors for train. 

> Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-244
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-244
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Pavitra Subramaniam
>            Priority: Minor
>         Attachments: Issue244.patch
>
>
> The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
>  
> 1. Remove the'disabled' property 
> 2. Rename the 'readOnly' property to 'disabled'  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Posted by "Pavitra Subramaniam (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-244?page=all ]

Pavitra Subramaniam updated ADFFACES-244:
-----------------------------------------

    Status: Patch Available  (was: Open)

> Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-244
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-244
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Pavitra Subramaniam
>            Priority: Minor
>
> The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
>  
> 1. Remove the'disabled' property 
> 2. Rename the 'readOnly' property to 'disabled'  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-244?page=comments#action_12443326 ] 
            
Simon Lessard commented on ADFFACES-244:
----------------------------------------

That issue will have to be fixed in at least two steps:

1) Remove usages of readOnly attribute throughout component.
2) Kill the attribute.

I'll take care of 1) for the process train since I know its code.

> Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-244
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-244
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Pavitra Subramaniam
>            Priority: Minor
>
> The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
>  
> 1. Remove the'disabled' property 
> 2. Rename the 'readOnly' property to 'disabled'  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Posted by "Pavitra Subramaniam (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-244?page=all ]

Pavitra Subramaniam updated ADFFACES-244:
-----------------------------------------

    Attachment:     (was: Issue244.patch)

> Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-244
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-244
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Pavitra Subramaniam
>            Priority: Minor
>         Attachments: Issue244.patch
>
>
> The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
>  
> 1. Remove the'disabled' property 
> 2. Rename the 'readOnly' property to 'disabled'  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Posted by "Gabrielle Crawford (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-244?page=all ]

Gabrielle Crawford reassigned ADFFACES-244:
-------------------------------------------

    Assignee: Gabrielle Crawford

> Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-244
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-244
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Pavitra Subramaniam
>         Assigned To: Gabrielle Crawford
>            Priority: Minor
>         Attachments: Issue244.patch
>
>
> The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
>  
> 1. Remove the'disabled' property 
> 2. Rename the 'readOnly' property to 'disabled'  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated ADFFACES-244:
----------------------------------------

        Fix Version/s: 1.0.0-incubating-core
    Affects Version/s: 1.0.0-incubating-core

> Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-244
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-244
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>    Affects Versions: 1.0.0-incubating-core
>            Reporter: Pavitra Subramaniam
>         Assigned To: Gabrielle Crawford
>            Priority: Minor
>             Fix For: 1.0.0-incubating-core
>
>         Attachments: Issue244.patch
>
>
> The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
>  
> 1. Remove the'disabled' property 
> 2. Rename the 'readOnly' property to 'disabled'  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Posted by "Pavitra Subramaniam (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-244?page=all ]

Pavitra Subramaniam updated ADFFACES-244:
-----------------------------------------

    Attachment: Issue244.patch

Made a minor change in TrainRenderer.java 
Changed the test script - train.xml

> Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-244
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-244
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Pavitra Subramaniam
>            Priority: Minor
>         Attachments: Issue244.patch
>
>
> The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
>  
> 1. Remove the'disabled' property 
> 2. Rename the 'readOnly' property to 'disabled'  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (ADFFACES-244) Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component

Posted by "Gabrielle Crawford (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-244?page=all ]

Gabrielle Crawford closed ADFFACES-244.
---------------------------------------

    Resolution: Fixed

patch applied

> Remove 'disabled' attribute and rename 'readOnly' to 'disabled' for commandNavigationItem component
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-244
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-244
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Pavitra Subramaniam
>         Assigned To: Gabrielle Crawford
>            Priority: Minor
>         Attachments: Issue244.patch
>
>
> The 'commandNavigationItem' supports 2 properties 'disabled' and 'readOnly' that more or less renders the same way. Since only one of them is really required & used in most use cases, the following changes are recommended
>  
> 1. Remove the'disabled' property 
> 2. Rename the 'readOnly' property to 'disabled'  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira