You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/21 01:29:03 UTC
[GitHub] [spark] flyrain opened a new pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
flyrain opened a new pull request #34054:
URL: https://github.com/apache/spark/pull/34054
### What changes were proposed in this pull request?
Change class ColumnarBatch to a non-final class
### Why are the changes needed?
To support better vectorized reading in multiple data source, ColumnarBatch need to be extendable. For example, To support row-level delete( https://github.com/apache/iceberg/issues/3141) in Iceberg's vectorized read, we need to filter out deleted rows in a batch, which requires ColumnarBatch to be extendable.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No test needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923504227
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923615443
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47981/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923726058
**[Test build #143470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143470/testReport)** for PR 34054 at commit [`3c7da3b`](https://github.com/apache/spark/commit/3c7da3b4220fcfcbde1c14d24608810322bb4e9c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class ColumnarBatch implements AutoCloseable `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923695596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923570198
**[Test build #143470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143470/testReport)** for PR 34054 at commit [`3c7da3b`](https://github.com/apache/spark/commit/3c7da3b4220fcfcbde1c14d24608810322bb4e9c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923615432
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47981/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] flyrain commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
flyrain commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-924138567
Thanks all for review! Thanks @dbtsai for the commit. Will file a followup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923964025
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923568613
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923615443
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47981/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923598233
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47981/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923504227
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-924099839
Merged into master. Thanks. Can you create a followup PR to add tests to show how you want to extend this so future PRs will not break it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923570198
**[Test build #143470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143470/testReport)** for PR 34054 at commit [`3c7da3b`](https://github.com/apache/spark/commit/3c7da3b4220fcfcbde1c14d24608810322bb4e9c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai closed pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
dbtsai closed pull request #34054:
URL: https://github.com/apache/spark/pull/34054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923734449
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143470/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34054: [SPARK-36814][SQL] Make class ColumnarBatch extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34054:
URL: https://github.com/apache/spark/pull/34054#issuecomment-923695596
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org