You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/28 06:27:44 UTC
[GitHub] [spark] sunchao opened a new pull request #34125: [SPARK-36873][BUILD] Add provided Guava dependency for network-yarn module
sunchao opened a new pull request #34125:
URL: https://github.com/apache/spark/pull/34125
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add provided Guava dependency to `network-yarn` module.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In Spark 3.1 and earlier the `network-yarn` module implicitly relies on Guava from `hadoop-client` dependency. This was changed by SPARK-33212 where we moved to shaded Hadoop client which no longer expose the transitive guava dependency. This was fine for a while since we were not using `createDependencyReducedPom` so it picks up the transitive dependency from `spark-network-common` instead. However, things start to break after SPARK-36835 where we restored `createDependencyReducedPom` and now it is no longer able to locate guava classes:
```
mvn test -pl common/network-yarn -Phadoop-3.2 -Phive-thriftserver -Pkinesis-asl -Pkubernetes -Pmesos -Pnetlib-lgpl -Pscala-2.12 -Pspark-ganglia-lgpl -Pyarn
...
[INFO] Compiling 1 Java source to /Users/sunchao/git/spark/common/network-yarn/target/scala-2.12/classes ...
[WARNING] [Warn] : bootstrap class path not set in conjunction with -source 8
[ERROR] [Error] /Users/sunchao/git/spark/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java:32: package com.google.common.annotations does not exist
[ERROR] [Error] /Users/sunchao/git/spark/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java:33: package com.google.common.base does not exist
[ERROR] [Error] /Users/sunchao/git/spark/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java:34: package com.google.common.collect does not exist
[ERROR] [Error] /Users/sunchao/git/spark/common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java:118: cannot find symbol
symbol: class VisibleForTesting
location: class org.apache.spark.network.yarn.YarnShuffleService
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Tested with the above `mvn` command and it's now passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929317369
+1, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928920969
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48183/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34125:
URL: https://github.com/apache/spark/pull/34125#discussion_r717328996
##########
File path: common/network-yarn/pom.xml
##########
@@ -73,6 +73,10 @@
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review comment:
I think it's always better to be explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929399296
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143676/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928934500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929056898
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929057758
I verified the fix locally.
Merging to master/3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929037127
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48189/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929115256
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48191/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34125:
URL: https://github.com/apache/spark/pull/34125#discussion_r717275688
##########
File path: common/network-yarn/pom.xml
##########
@@ -73,6 +73,10 @@
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review comment:
The default is `provided`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928896439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929138864
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48191/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928962909
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48183/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928957830
Yeah, i think because it uses SBT. Problem is that we can't test all of the combinations. We will have SBT / Maven / Hadoop / JDK / Hive / Python / ... combinations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928896439
**[Test build #143671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143671/testReport)** for PR 34125 at commit [`4004dca`](https://github.com/apache/spark/commit/4004dcaa426e7301bdee36d842ac74e4c9b0c36f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928962909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34125:
URL: https://github.com/apache/spark/pull/34125#discussion_r717338866
##########
File path: common/network-yarn/pom.xml
##########
@@ -73,6 +73,10 @@
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review comment:
Thanks. Added provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928962909
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48183/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929086047
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48191/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34125: [SPARK-36873][BUILD] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928894143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929138864
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48191/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929052879
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48189/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929008973
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143671/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928958624
SBT is being used in GA because in order to partially run the tests quickly (so we can run them in parallel). Maven case, we run the basic build and tests in Jenkins but I don't think we test all of these profiles, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929056898
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928958624
SBT is being used in GA in order to partially run the tests quickly (so we can run them in parallel). Maven case, we run the basic build and tests in Jenkins but I don't think we test all of these profiles, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928968755
**[Test build #143676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143676/testReport)** for PR 34125 at commit [`ca4419b`](https://github.com/apache/spark/commit/ca4419b9b46819a2ae3484cb9386d22e469b8a0d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928962909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #34125:
URL: https://github.com/apache/spark/pull/34125#discussion_r717330663
##########
File path: common/network-yarn/pom.xml
##########
@@ -73,6 +73,10 @@
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review comment:
+1 with @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929317369
+1, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34125:
URL: https://github.com/apache/spark/pull/34125#discussion_r717275688
##########
File path: common/network-yarn/pom.xml
##########
@@ -73,6 +73,10 @@
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review comment:
The default is `provided`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #34125:
URL: https://github.com/apache/spark/pull/34125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34125:
URL: https://github.com/apache/spark/pull/34125#discussion_r717338866
##########
File path: common/network-yarn/pom.xml
##########
@@ -73,6 +73,10 @@
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review comment:
Thanks. Added provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928957830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928990368
**[Test build #143671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143671/testReport)** for PR 34125 at commit [`4004dca`](https://github.com/apache/spark/commit/4004dcaa426e7301bdee36d842ac74e4c9b0c36f).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34125: [SPARK-36873][BUILD] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928901586
Not sure why this was not caught by either the Jenkins or GitHub CI before - maybe because both of them are using SBT instead of Maven? I wonder if the `test-maven` option still works for the Jenkins CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929052879
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48189/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #34125:
URL: https://github.com/apache/spark/pull/34125#discussion_r717330663
##########
File path: common/network-yarn/pom.xml
##########
@@ -73,6 +73,10 @@
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review comment:
+1 with @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929005388
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48189/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929008973
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143671/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928958624
SBT is being used in GA in order to partially run the tests quickly (so we can run them in parallel). Maven case, we run the basic build and tests in Jenkins but I don't think we test all of these profiles, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-929399296
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143676/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928934500
> Not sure why this was not caught by either the Jenkins or GitHub CI before - maybe because both of them are using SBT instead of Maven? I wonder if the test-maven option still works for the Jenkins CI.
cc @HyukjinKwon could you check the current GA test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34125:
URL: https://github.com/apache/spark/pull/34125#discussion_r717328996
##########
File path: common/network-yarn/pom.xml
##########
@@ -73,6 +73,10 @@
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review comment:
I think it's always better to be explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928896439
**[Test build #143671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143671/testReport)** for PR 34125 at commit [`4004dca`](https://github.com/apache/spark/commit/4004dcaa426e7301bdee36d842ac74e4c9b0c36f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928962789
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48183/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34125: [SPARK-36873][BUILD] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928894143
cc @gengliangwang @srowen @JoshRosen @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34125: [SPARK-36873][BUILD][test-maven] Add provided Guava dependency for network-yarn module
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34125:
URL: https://github.com/apache/spark/pull/34125#issuecomment-928896439
**[Test build #143671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143671/testReport)** for PR 34125 at commit [`4004dca`](https://github.com/apache/spark/commit/4004dcaa426e7301bdee36d842ac74e4c9b0c36f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org