You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Artem Harutyunyan <ar...@mesosphere.io> on 2015/11/14 18:07:30 UTC
Re: Review Request 40241: Fixed apply-reviews.py to prevent git commit
editors from hanging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 9:07 a.m.)
Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Summary (updated)
-----------------
Fixed apply-reviews.py to prevent git commit editors from hanging.
Repository: mesos
Description
-------
`subprocess.check_output()` used pipes to capture STDOUT and STDERR. Because of this certain editors (such as vi) would hang when invoked during git commit. To mitigate that I switched to `subprocess.call()` and did some code refactoring to accomodate that change.
Diffs
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/40241/diff/
Testing
-------
Thanks,
Artem Harutyunyan
Re: Review Request 40241: Fixed apply-reviews.py to prevent git commit
editors from hanging.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/#review107981
-----------------------------------------------------------
Ship it!
Thanks for fixing this, I committed it without committing 40225 since they looked independent.
- Ben Mahler
On Nov. 14, 2015, 5:07 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40241/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2015, 5:07 p.m.)
>
>
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `subprocess.check_output()` used pipes to capture STDOUT and STDERR. Because of this certain editors (such as vi) would hang when invoked during git commit. To mitigate that I switched to `subprocess.call()` and did some code refactoring to accomodate that change.
>
>
> Diffs
> -----
>
> support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
>
> Diff: https://reviews.apache.org/r/40241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Artem Harutyunyan
>
>