[jira] [Commented] (KAFKA-649) Cleanup log4j logging

["Jay Kreps (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626998#comment-13626998 ] 

Jay Kreps commented on KAFKA-649:
---------------------------------

+1
A few minor issues:
1. Typo: "No broker is ISR is alive"
2. Can we spell out ISR. "In-sync replica set" is a little more wordy but it is immediately obvious what it means. My overall concern is that our logging is impossible to read for anyone but a Kafka engineer.
3. correlationId => correlation id
4. controllerEpoch => controllerEpoch
5. zkPath => zookeeper path

All of these fixes look good. Do you feel after this patch the logs are clean enough to be ready for the official 0.8 release or is this just one installment?
                
> Cleanup log4j logging
> ---------------------
>
>                 Key: KAFKA-649
>                 URL: https://issues.apache.org/jira/browse/KAFKA-649
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>            Assignee: Jun Rao
>            Priority: Blocker
>         Attachments: kafka-649.patch
>
>
> Review the logs and do the following:
> 1. Fix confusing or duplicative messages
> 2. Assess that messages are at the right level (TRACE/DEBUG/INFO/WARN/ERROR)
> It would also be nice to add a log4j logger for the request logging (i.e. the access log) and another for the controller state change log, since these really have their own use cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira