You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/30 18:40:41 UTC
[GitHub] codecov-io edited a comment on issue #3528: Adding support for
bloom filter
codecov-io edited a comment on issue #3528: Adding support for bloom filter
URL: https://github.com/apache/incubator-pinot/pull/3528#issuecomment-443069884
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3528?src=pr&el=h1) Report
> Merging [#3528](https://codecov.io/gh/apache/incubator-pinot/pull/3528?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f1559a723346a7ae9e4006c5347bd8f6cfdbe2b8?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `54.8%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3528/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3528?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3528 +/- ##
============================================
- Coverage 70.88% 70.74% -0.15%
Complexity 4 4
============================================
Files 997 1004 +7
Lines 45779 45971 +192
Branches 6137 6160 +23
============================================
+ Hits 32449 32520 +71
- Misses 11208 11321 +113
- Partials 2122 2130 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3528?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pinot/core/segment/store/ColumnIndexDirectory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvc3RvcmUvQ29sdW1uSW5kZXhEaXJlY3RvcnkuamF2YQ==) | `93.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ava/com/linkedin/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2NvbW1vbi9EYXRhU291cmNlLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/pinot/core/segment/creator/impl/V1Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvY3JlYXRvci9pbXBsL1YxQ29uc3RhbnRzLmphdmE=) | `33.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...startree/v2/store/StarTreeDimensionDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3N0YXJ0cmVlL3YyL3N0b3JlL1N0YXJUcmVlRGltZW5zaW9uRGF0YVNvdXJjZS5qYXZh) | `72.72% <0%> (-3.47%)` | `0 <0> (ø)` | |
| [.../core/segment/index/readers/BloomFilterReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvcmVhZGVycy9CbG9vbUZpbHRlclJlYWRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ot/core/segment/store/SegmentLocalFSDirectory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvc3RvcmUvU2VnbWVudExvY2FsRlNEaXJlY3RvcnkuamF2YQ==) | `63.84% <0%> (-1.11%)` | `0 <0> (ø)` | |
| [...re/startree/v2/store/StarTreeMetricDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3N0YXJ0cmVlL3YyL3N0b3JlL1N0YXJUcmVlTWV0cmljRGF0YVNvdXJjZS5qYXZh) | `56.52% <0%> (-2.57%)` | `0 <0> (ø)` | |
| [.../pinot/core/segment/index/SegmentMetadataImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvU2VnbWVudE1ldGFkYXRhSW1wbC5qYXZh) | `81.29% <0%> (-0.28%)` | `0 <0> (ø)` | |
| [...inot/core/segment/store/FilePerIndexDirectory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvc3RvcmUvRmlsZVBlckluZGV4RGlyZWN0b3J5LmphdmE=) | `89.39% <100%> (+1.06%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/segment/index/loader/SegmentPreProcessor.java](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvbG9hZGVyL1NlZ21lbnRQcmVQcm9jZXNzb3IuamF2YQ==) | `80% <100%> (+1.21%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/incubator-pinot/pull/3528/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3528?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3528?src=pr&el=footer). Last update [f1559a7...bd83969](https://codecov.io/gh/apache/incubator-pinot/pull/3528?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org