[GitHub] [pinot] jackjlli commented on a diff in pull request #10777: Redefine the semantics of SEGMENT_STREAMED_DOWNLOAD_UNTAR_FAILURES metric to count individual segment fetch failures.

["jackjlli (via GitHub)" <gi...@apache.org>]

jackjlli commented on code in PR #10777:
URL: https://github.com/apache/pinot/pull/10777#discussion_r1200829713


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/BaseSegmentFetcher.java:
##########
@@ -102,7 +104,8 @@ public void fetchSegmentToLocal(List<URI> uris, File dest)
     });
   }
 
-  public File fetchUntarSegmentToLocalStreamed(URI uri, File dest, long rateLimit)
+  public File fetchUntarSegmentToLocalStreamed(URI uri, File dest, long rateLimit,
+      AtomicInteger attempts)

Review Comment:
   Now that we record the attempts for this signature. Do we plan to add this attempt to the other one(s) as well? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org