You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/26 07:10:52 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #6083: I found that when using the ehcache1.* version, the agent will throw NPE in the plugin, so I fixed it

wu-sheng commented on pull request #6083:
URL: https://github.com/apache/skywalking/pull/6083#issuecomment-751328625


   The codes you are changing is ehcache 2.x plugin, we never said this supports 1.x. If you want to support more versions, adding NULL check is not a good idea. You should find why the required info is not missing and add it back.
   
   By the way, we provided the code style file in the root folder, please don't format the codes randomly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org