You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2020/08/03 10:27:57 UTC

[commons-lang] branch master updated: LANG-1593: Add unit test with OP's use-case that shows unexpected difference in behaviour.

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new 4897c88  LANG-1593: Add unit test with OP's use-case that shows unexpected difference in behaviour.
4897c88 is described below

commit 4897c8869b7050ba98b19c743762c10a56581ee4
Author: Gilles Sadowski <gi...@gmail.com>
AuthorDate: Mon Aug 3 12:24:13 2020 +0200

    LANG-1593: Add unit test with OP's use-case that shows unexpected difference in behaviour.
    
    Unit test is set to "@Disabled" to not fail the build.
---
 src/test/java/org/apache/commons/lang3/StringUtilsTest.java | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
index 7c657d0..99ebed7 100644
--- a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
@@ -45,6 +45,7 @@ import java.util.regex.PatternSyntaxException;
 import org.apache.commons.lang3.mutable.MutableInt;
 import org.apache.commons.lang3.text.WordUtils;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Disabled;
 
 /**
  * Unit tests for methods of {@link org.apache.commons.lang3.StringUtils}
@@ -1341,6 +1342,15 @@ public class StringUtilsTest {
         assertEquals("foo2", StringUtils.join(MIXED_TYPE_LIST));
     }
 
+    @Disabled
+    @Test
+    public void testLang1593() {
+        final int[] arr = new int[] {1, 2, 3, 4, 5, 6, 7};
+        final String expected = StringUtils.join(arr, '-');
+        final String actual = StringUtils.join(arr, "-");
+        assertEquals(expected, actual);
+    }
+
     //-----------------------------------------------------------------------
     @Test
     public void testJoin_Objects() {